Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

browser.resizeWindow vs driver.setRect - align API #106

Open
yashaka opened this issue Aug 19, 2019 · 0 comments
Open

browser.resizeWindow vs driver.setRect - align API #106

yashaka opened this issue Aug 19, 2019 · 0 comments

Comments

@yashaka
Copy link
Collaborator

yashaka commented Aug 19, 2019

questions here...

1
should resizeWindow signature match setRect signature (accepting Partial<IRectangle> with x & y props...)?

2
if yes, should we rename it?
since resizeWindow({x: 100, y:200}) sounds awkward...

3
rename to setDimensions?
image
image

4
or should we leave it as it is and add another method? (like setDimensions...)

5
should we deprecate resizeWindow?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yashaka