Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception on LoggableTrait when the changed field is DateTimeImmutable type #717

Open
adnen-chouibi opened this issue Jan 9, 2023 · 0 comments · May be fixed by #721
Open

Exception on LoggableTrait when the changed field is DateTimeImmutable type #717

adnen-chouibi opened this issue Jan 9, 2023 · 0 comments · May be fixed by #721

Comments

@adnen-chouibi
Copy link

adnen-chouibi commented Jan 9, 2023 •
edited
Loading

We need to check if $item is an instance of DateTimeInterface instead of DateTime on LoggableTrait.getUpdateLogMessage()
in order to check both type DateTime and DateTimeImmutable
jerome-fix pushed a commit to jerome-fix/DoctrineBehaviors that referenced this issue Feb 11, 2023
[loggable] Allows the use of DateTimeImmutable in entities
2d3daac 
fixes KnpLabs#717
@jerome-fix jerome-fix linked a pull request Feb 11, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[loggable] Allows the use of DateTimeImmutable in entities jerome-fix/DoctrineBehaviors
1 participant
@adnen-chouibi