Elko Super Thermostat - Configurable reporting of local temperature based on sensor choice #8313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Koenkk
reviewed
Nov 14, 2024
src/converters/fromZigbee.ts
Outdated
| if (data.localTemp !== undefined) { | ||
| const value = precisionRound(msg.data['localTemp'], 2) / 100; | ||
| const valuesFloorSensor = ['floor', 'supervisor_floor']; | ||
| const sensorType = globalStore.getValue(msg.endpoint, 'sensor'); |
There was a problem hiding this comment.
It would be better to get the value from the meta.state, the globalStore is always reset after every z2m restart.
There was a problem hiding this comment.
Thank you for the valuable input. I agree (now that I understand the meta.state capability) that this is much better and I've made the change.
Koenkk
reviewed
Nov 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.