Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] RISC-V support #22824

Merged
merged 71 commits into from
Dec 11, 2024
Merged

[RFC] RISC-V support #22824

merged 71 commits into from
Dec 11, 2024

Conversation

stintel
Copy link
Contributor

@stintel stintel commented May 29, 2024

This PR updates the Alpine base container to Alpine 3.20, which supports the RISC-V architecture, and enables 64-bit RISC-V builds in Github actions.

I understand this probably won't be merged soon, due to the Alpine bump and the potential for regressions, but like this people who have RISC-V hardware lying around, can give it a try. I'm personally running a locally built zigbee2mqtt container on the VisionFive 2 for the past week and it's been working rather well.

@Koenkk
Copy link
Owner

Koenkk commented May 30, 2024

Does it also work with Alpine 3.18? We currently cannot migrate to 3.20 since this makes the Docker build hang.

@stintel
Copy link
Contributor Author

stintel commented May 30, 2024

Does it also work with Alpine 3.18?

It does not, Alpine 3.20 is the first version that supports the RISC-V architecture.

@Koenkk
Copy link
Owner

Koenkk commented May 30, 2024

Then I will hold this until the bug in Node 20 is fixed (Alpine 3.18 is the last to use Node 18 which doesnt have this bug)

@stintel
Copy link
Contributor Author

stintel commented May 30, 2024

Understood! Out of curiosity, is there any issue for that bug in Node 20? Also, interestingly enough, CI for this PR succeeded, while it previously hung in my fork and was terminated after 360 minutes.

@Koenkk
Copy link
Owner

Koenkk commented May 30, 2024

Ci succeeds because it doesnt build the container (which is what fails for armv7 and 6 platforms on node 20)

@Nerivec
Copy link
Collaborator

Nerivec commented Dec 11, 2024

serialport currently does not provide support for riscv64.
https://serialport.io/docs/guide-platform-support#supported-platforms-and-architectures

@Koenkk
Copy link
Owner

Koenkk commented Dec 11, 2024

riscv is not officially supported by serialport so we cannot guarantee it works. @stintel could you do a check with the latest-dev image?

@Koenkk Koenkk merged commit e23d300 into Koenkk:dev Dec 11, 2024
11 checks passed
@stintel
Copy link
Contributor Author

stintel commented Dec 11, 2024

@Koenkk had to add adapter: zstack to configuration.yaml but seems to be working fine now. This is awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants