Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove oneOf bool/obj from settings schema #25195

Merged
merged 8 commits into from
Dec 17, 2024
Merged

Conversation

Koenkk
Copy link
Owner

@Koenkk Koenkk commented Dec 14, 2024

Docs: Koenkk/zigbee2mqtt.io#3331

TODO:

  • Test with HA addon

From @Nerivec in #25192

So, this turned into a much bigger job than anticipated...

  • Migration system wasn't quite ready for multi-step, fixed that...
  • Bumped settings version to 2.1 (provides support for dev users that already have migrated to 2.0.0)
  • Removed oneOf for homeassistant, availability and frontend => only object
  • Some nice code cleanups here and there with this one
  • Added defaults in schema and settings
  • Renamed getInternalSettings to getPersistedSettings
  • Updated example yaml
  • Fix tests

TODO:

  • If you want to keep Z2M version in sync with settings version, would need to update to 2.1.0
  • If not, probably should rename the log from migration-2.0.x-to-2.1.x.log to migration-2-to-2.1.log (same for tests labels)
  • Which is the expected default for homeassistant.status_topic (several occurrences)?
  • hass/status
  • homeassistant/status

@Koenkk Koenkk changed the title Fix/refactor settings fix: Remove oneOf bool/obj from settings schema Dec 15, 2024
@Koenkk Koenkk merged commit c3b4628 into dev Dec 17, 2024
21 checks passed
@Koenkk Koenkk deleted the fix/refactor-settings branch December 17, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants