[bug] best_orders returns incorrect is_mine

[SirSevenG]

best_orders rpc returns is_mine: false for own orders.

Tested on

commit e98c61217451f38f54ae5d60f3d3b012ab2ac962 (HEAD -> mm2.1, tag: beta-2.1.3731, origin/mm2.1, origin/HEAD)
Merge: 8bf6ed3c3 ed40dc1e0

To reproduce:

• create maker order
• Find your order in best_orders rpc
• is_mine is set to false

AE: my_orders response: https://pastebin.ubuntu.com/p/Jn8bQdpH67/
best orders response: https://pastebin.ubuntu.com/p/bFhwTqGyJj/

[artemii235]

Thanks for the report! We should exclude orders of the node from the best_orders response. It doesn't make sense to have them there.

[shamardy]

@smk762 This should be fixed in the latest dev branch. A new parameter exclude_mine was added to best_orders 2.0 request that has to be set to true to exclude the user's orders from the best_orders 2.0 response. We decided to do it this way in case somebody was relying on their orders to be returned from best_orders 2.0 without using this new parameter.

[smk762]

Closing, confirmed fix. Docs PR for exclude_mine param at KomodoPlatform/komodo-docs-mdx#187