Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Tendermind fees too expensive #2371

Closed
smk762 opened this issue Sep 22, 2023 · 1 comment
Closed

[BUG]: Tendermind fees too expensive #2371

smk762 opened this issue Sep 22, 2023 · 1 comment
Labels
awaiting API bug Something isn't working

Comments

@smk762
Copy link
Collaborator

smk762 commented Sep 22, 2023

ref: KomodoPlatform/komodo-defi-framework#1894

This was mentioned previously in flutter app, the reply was for guis to use the "custom fee" in back end until a global solution is available.

In api repo, there is a constant for all tendermint coins, though fees may vary between iris/atom/cosmos. https://github.com/KomodoPlatform/komodo-defi-framework/blob/main/mm2src/coins/tendermint/ibc/mod.rs#L6

@smk762 smk762 added the bug Something isn't working label Sep 22, 2023
@cipig
Copy link
Member

cipig commented Sep 22, 2023

In api repo, there is a constant for all tendermint coins, though fees may vary between iris/atom/cosmos. https://github.com/KomodoPlatform/komodo-defi-framework/blob/main/mm2src/coins/tendermint/ibc/mod.rs#L6

That is GAS_LIMIT, not GAS_PRICE... the limit is to limit the amount of gas spent on certain operations... if the limit is exceeded during execution, the operation is cancelled... this is to prevent spending 10000 ATOM on a single tx (eg if you have an endless loop in your contract)

The price for the tx is GAS_USED * GAS_PRICE... i can't find any gas price definition in coins file, so i assume it's using some default... or the result of gas_price call to RPC nodes, that's how ERC20 is working
if gas_price calls are used, then maybe the calculation is wrong or RPC nodes return a too high fee
we could also set a gas price in coins file to fix this if the gas_price returns nonsense
What is the usual txfee in USD?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting API bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants