Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: animates ProgressIcon #82

Merged
merged 4 commits into from
Sep 29, 2023
Merged

feat: animates ProgressIcon #82

merged 4 commits into from
Sep 29, 2023

Conversation

kleinfreund
Copy link
Contributor

Summary

Animates ProgressIcon using SVG animate.

Notes

Putting this up as a proposal/suggestion so we can figure out how to handle the need for an animated progress icon.

  • Downside: Using SVG animate won’t allow us to use a prefers-reduced-motion media query to disable the animation (as far as I know anyway). The same downside is applicable to using only inline styles.
  • Question: Should there be a boolean prop controlling whether the icon is animated?

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@kleinfreund kleinfreund self-assigned this Sep 29, 2023
@CLAassistant
Copy link

CLAassistant commented Sep 29, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Animates ProgressIcon using SVG `animate`.

Signed-off-by: Philipp Rudloff <[email protected]>
@kleinfreund kleinfreund force-pushed the feat/animate-progress-icon branch from cc578d6 to 5dc741a Compare September 29, 2023 08:03
@kleinfreund kleinfreund marked this pull request as ready for review September 29, 2023 15:23
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamdehaven adamdehaven merged commit 0861cd9 into main Sep 29, 2023
@adamdehaven adamdehaven deleted the feat/animate-progress-icon branch September 29, 2023 15:45
kongponents-bot pushed a commit that referenced this pull request Sep 29, 2023
# [1.7.0](v1.6.0...v1.7.0) (2023-09-29)

### Features

* animates ProgressIcon ([#82](#82)) ([0861cd9](0861cd9))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kleinfreund kleinfreund removed their assignment Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants