-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: animates ProgressIcon #82
Conversation
|
Animates ProgressIcon using SVG `animate`. Signed-off-by: Philipp Rudloff <[email protected]>
cc578d6
to
5dc741a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# [1.7.0](v1.6.0...v1.7.0) (2023-09-29) ### Features * animates ProgressIcon ([#82](#82)) ([0861cd9](0861cd9))
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
Animates ProgressIcon using SVG
animate
.Notes
Putting this up as a proposal/suggestion so we can figure out how to handle the need for an animated progress icon.
animate
won’t allow us to use aprefers-reduced-motion
media query to disable the animation (as far as I know anyway). The same downside is applicable to using only inline styles.PR Checklist