Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding more details to README #578

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Adding more details to README #578

merged 1 commit into from
Oct 28, 2022

Conversation

Hayk-S
Copy link
Contributor

@Hayk-S Hayk-S commented Oct 28, 2022

No description provided.

@Hayk-S Hayk-S requested a review from hutchic October 28, 2022 17:18
@CLAassistant
Copy link

CLAassistant commented Oct 28, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@curiositycasualty curiositycasualty enabled auto-merge (squash) October 28, 2022 18:25
@curiositycasualty
Copy link
Contributor

Actually, @Hayk-S Can I get you to format this commit as a semantic one?
It would look something like: chore(docs): adding more details to README

This repo uses the semantic release action to determine how/what to release automagically: https://github.com/Kong/kong-build-tools/blob/master/.github/workflows/release.yaml#L17-L21

@Hayk-S Hayk-S force-pushed the contrib/readme-details branch from 7d361aa to 3dca400 Compare October 28, 2022 19:37
@Hayk-S
Copy link
Contributor Author

Hayk-S commented Oct 28, 2022 •
edited
Loading

@curiositycasualty can you please check the commit now?

@curiositycasualty curiositycasualty enabled auto-merge (squash) October 28, 2022 19:38
@curiositycasualty
Copy link
Contributor

@Hayk-S Looks good to me. Automerge enabled.

@Hayk-S
Copy link
Contributor Author

Hayk-S commented Oct 28, 2022

Thanks @curiositycasualty

@curiositycasualty curiositycasualty merged commit ad08666 into master Oct 28, 2022
@curiositycasualty curiositycasualty deleted the contrib/readme-details branch October 28, 2022 20:53
@github-actions
Copy link

🎉 This PR is included in version 4.35.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curiositycasualty curiositycasualty curiositycasualty approved these changes

@hutchic hutchic Awaiting requested review from hutchic

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hayk-S @CLAassistant @curiositycasualty