feat(ktreelist): add collapse/expand option [KHCP-14716] #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DariaYeremina
requested review from
adamdehaven,
jillztom,
Justineo and
a team
as code owners
arashsheyda
reviewed
Jan 20, 2025
adamdehaven
reviewed
Jan 20, 2025
adamdehaven
reviewed
Jan 21, 2025
|
The indentation here needs to be tweaked so that all of the top-level items are aligned on the left, and the children are indented visually to the right of the parent |
DariaYeremina
force-pushed
the
feat/KHCP-14716-enhance-k-tree-list-to-support-collapsable-parent-items
branch
from
31e0e4a to
9249d08
Compare
adamdehaven
requested changes
Jan 21, 2025
| v-if="hasIcon" | ||
| class="tree-item-icon" | ||
| data-testid="tree-item-icon" | ||
| <ChevronDownIcon |
There was a problem hiding this comment.
A few issues:
- The chevron should point "down" when expanded, and "right" when collapsed.
- Clicking the button seems to toggle the icon direction.
- I can tab to the icon to collapse/expand but dont have a way to actually trigger it
- After reordering the items, but not touching collapse icon button, the icon direction seems to change on the docs site.
- After reordering, I can no longer expand/collapse the items on the first click consistently. Sometimes it takes several clicks.
|
For a child node that itself is not expandable, can we remove the "gap" on the left between the item and the line? |
adamdehaven
reviewed
Jan 22, 2025
Comment on lines
286
to
291
| // set previous icon state after DOM was re-rendered | ||
| await nextTick(() => { | ||
| treeItems.value?.forEach((item: typeof KTreeItem) => { | ||
| item?.setExpandedValue(childrenVisibilityMap.value.get(item?.id)) | ||
| }) | ||
| }) |
There was a problem hiding this comment.
nit: can we update the syntax here to match the other usage in the repo?
Suggested change
| // set previous icon state after DOM was re-rendered | |
| await nextTick(() => { | |
| treeItems.value?.forEach((item: typeof KTreeItem) => { | |
| item?.setExpandedValue(childrenVisibilityMap.value.get(item?.id)) | |
| }) | |
| }) | |
| // set previous icon state after DOM was re-rendered | |
| await nextTick() | |
| treeItems.value?.forEach((item: typeof KTreeItem) => { | |
| item?.setExpandedValue(childrenVisibilityMap.value.get(item?.id)) | |
| }) |
adamdehaven
reviewed
Jan 22, 2025
Comment on lines
331
to
335
| await nextTick(() => { | ||
| if (props.collapsible) { | ||
| triggerCollapse() | ||
| } | ||
| }) |
There was a problem hiding this comment.
ah can we update the syntax here as well?
DariaYeremina
deleted the
feat/KHCP-14716-enhance-k-tree-list-to-support-collapsable-parent-items
branch
kongponents-bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
# [9.18.0](v9.17.5...v9.18.0) (2025-01-22) ### Features * **ktreelist:** add collapse/expand option [KHCP-14716] ([#2583](#2583)) ([a5490a3](a5490a3))
|
🎉 This PR is included in version 9.18.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://konghq.atlassian.net/browse/KHCP-14716
collapsibleprop to enable collapse/expand feature.collapseAllprop to allow initial collapse/expand for all items.