fix(ktabledata): client sort should not trigger cache invalidation #2606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Justineo
requested review from
adamdehaven,
jillztom and
a team
as code owners
✅ Deploy Preview for kongponents-sandbox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for kongponents ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
portikM
approved these changes
Feb 10, 2025
| @@ -378,8 +391,6 @@ const tableFetcherCacheKey = computed((): string => { | |||
| return `k-table_${identifierKey}` | |||
| }) | |||
|
|
|||
| watch(tableFetcherCacheKey, (key: string) => console.log(key)) | |||
|
🎉 This PR is included in version 9.20.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
KM-946
client-sortis enabled, exclude sort-related parameters from the cache key.console.log.Konnect Preview: https://github.com/Kong/konnect-ui-apps/pull/5733