Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarry entities not impacted by lighting #597

Open
valknight opened this issue Sep 23, 2024 · 1 comment
Open

Quarry entities not impacted by lighting #597

valknight opened this issue Sep 23, 2024 · 1 comment

Comments

@valknight
Copy link

valknight commented Sep 23, 2024

Describe the bug

Quarry "arm" and drill is unlit. With shaders on, this causes the arm to potentially render into the threshold for bloom, or otherwise very bright.

I've taken a cursory look through the source code, but unfortunately I'm unfamiliar with how Minecraft mod rendering works and it's past midnight 😅

To Reproduce

Steps to reproduce the behavior:

  1. Create quarry
  2. Power quarry

Expected:
Quarry entity is impacted by lighting

Actual:
Quarry entity is not impacted by lighting

Reproduction screenshot:

unlit_minearm

Note the arm is brighter in this example than the blocks around it

Versions

  • Minecraft version: 1.21.1
  • Single Player or Multi Player?: Multi Player + Single Player impacted
  • Fabric version: 0.16.5
  • QuarryPlus version: 21.1.103
Other mods

I can imagine potentially one of the rendering mods I'm using being an issue - when I have some spare time, I'll double check to see if this repros without this :)

Crash report or logs

  • TODO: But, given this is a graphical issue, the screenshot is a sort of log 😄 (not really, I just need a log without multiplayer chat in it)
@Kotori316
Copy link
Owner

I pass the "fixed" light to renderer, but I should get the light value for each position. I don't think getting light value for all position arm exists in every subticks is light, but I'll see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants