Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table headers and footers are not displayed when nothing else is on the page #129

Closed
langusta opened this issue Oct 22, 2013 · 2 comments · Fixed by #1012
Closed

Table headers and footers are not displayed when nothing else is on the page #129

langusta opened this issue Oct 22, 2013 · 2 comments · Fixed by #1012
Labels
bug Existing features not working as expected
Milestone
51

Comments

@langusta
Copy link

When I print following webpage, the first table (with header) is not printed, unless I remove tags. I got the error when I was trying to print irregular tables (some of the tables were connected to look like one table).

http://langust.x10.mx/test_wrongly_printed_header.html
@liZe liZe changed the title <thead> can cause table not to be printed Table headers and footers are not displayed when there's no table body Aug 14, 2015
@liZe liZe added bug Existing features not working as expected conformance labels Aug 14, 2015
@liZe liZe changed the title Table headers and footers are not displayed when there's no table body Table headers and footers are not displayed when nothing else is on the page Aug 14, 2015
@liZe
Copy link
Member

liZe commented Aug 14, 2015

What a funny bug!

  • working: <html>text<table style="border: 2px solid"><thead><tr><th>Header
  • not working <html><table style="border: 2px solid"><thead><tr><th>Header

This is caused by this line (and the same ones in the next blocks):

WeasyPrint/weasyprint/layout/tables.py

Line 281 in f0da037

if header and not resume_at:

This test asserts that if there's nothing on the page, that's because nothing can be be drawn, so the header/footer doesn't fit. But when there's nothing else to draw on the page, that's normal :).

@liZe liZe removed the bug Existing features not working as expected label Apr 1, 2019
@liZe liZe mentioned this issue Dec 15, 2019
Closed
@liZe liZe added bug Existing features not working as expected and removed conformance labels Dec 17, 2019
@liZe liZe added this to the 51 milestone Dec 18, 2019
@liZe
Copy link
Member

liZe commented Dec 18, 2019

It’s fixed in branch fix_129 (surprise!), we need tests before merging.

@grewn0uille grewn0uille mentioned this issue Dec 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected
Projects
None yet
Milestone
51
Development

Successfully merging a pull request may close this issue.

Fix rendering for header and footer on empty tables Kozea/WeasyPrint
2 participants
@liZe @langusta