Fonts with variable weight don’t work #1454

grewn0uille · 2021-09-28T14:03:25Z

No description provided.

mahiki · 2021-10-02T19:54:51Z

I experienced the same, have been meaning to provide a minimal example. Basically the HMTL page is showing (in browsers or other clients) bold text, but after running

weasyprint file.html  file.pdf

The output looks the same but no bold.

Example of HTML:

<style>
  table {
      border-collapse: collapse;
      font-family: Calibri, sans-serif;
      font-size: 12px;
      border: 2px solid #000;
  }
  tr.header {
      background: black;
      color: white;
      font-weight: bold;
  }
</style>
<body>
<table>
  <tr class = "header">
    <th style = "text-align: left;">HEADER 1</th>
    <th style = "text-align: left;">HEADER METRIC 1 (%)</th>
    <th style = "text-align: center;"></th>
    <th style = "text-align: center;"></th>
    <th style = "text-align: center;"></th>
  </tr>
  <tr>
    <td style = "background: #dbdbdb; font-weight: bold; text-align: left;">BOLD ROW 1</td>
    <td style = "background: #dbdbdb; font-weight: bold; text-align: left;">CATEGORY</td>
    <td style = "background: #dbdbdb; font-weight: bold; text-align: center;">89.09</td>
    <td style = "background: #dbdbdb; font-weight: bold; text-align: center;">91.31</td>
    <td style = "background: #dbdbdb; font-weight: bold; text-align: center;">91.18</td>
  </tr>
...

liZe · 2021-10-04T08:39:35Z

This bug is not easy to fix, because:

there’s probably no way with Harfbuzz to get a non-variable font out of a variable font,
the PDF specification doesn’t allow variations to be set in PDF,
I can’t find an easy way in fontTools to reset the default value of a variation setting.

If anyone knows (or want to learn) fontTools, that would be nice to have a way to set the default value of a variation setting in a font.

aschmitz · 2021-12-12T19:49:02Z

Just to add some notes from things I've been poking around at this week[end], FontTools' varLib.instancer supports "instancing" a variable font (including fixing variation axes to a specific value). Its documentation implies that it can only remove axes, not set them to specific values, but that appears to be outdated, and fonttools/fonttools#1537 appears to indicate it can indeed do both.

Harfbuzz has had some discussion around the point, and it appears as though Google Fonts would like Harfbuzz to support this as well (see harfbuzz/harfbuzz#1707), but harfbuzz/harfbuzz#2112 is their issue for it and it sounds like there's a fair bit of work to be done before they get there.

J-Cake · 2022-08-19T13:25:47Z

Any update on this? I'm using exactly all of the things causing issues mentioned above. It's quite important to me because I have a pretty sophisticated markdown-based typesetting setup, where bold is kinda a must-have. I've worked with HarfBuzz before, so I kinda know my way around, so if I can be of assistance I'll do my best to help, but I'm wondering if anyone has gotten closer to this?
Thanks

liZe · 2022-08-19T13:47:25Z

@J-Cake Hi!

Any update on this?

Unfortunately no.

I've worked with HarfBuzz before, so I kinda know my way around, so if I can be of assistance I'll do my best to help

Then your help could be very useful! I didn’t take the time (yet) to check what’s new in harfbuzz/harfbuzz#2112, but the situation seems to have been improved.

Here’s how we get the Harfbuzz font face out of the Pango font:

WeasyPrint/weasyprint/pdf/stream.py

Lines 261 to 266 in 67cd41a

    
           def add_font(self, pango_font): 
        
               hb_font = pango.pango_font_get_hb_font(pango_font) 
        
               hb_face = harfbuzz.hb_font_get_face(hb_font) 
        
               if hb_face not in self._fonts: 
        
                   self._fonts[hb_face] = Font(pango_font, hb_face) 
        
               return self._fonts[hb_face]

And here’s how we get the font face blob:

WeasyPrint/weasyprint/pdf/stream.py

Lines 18 to 23 in 67cd41a

    
           hb_blob = ffi.gc( 
        
               harfbuzz.hb_face_reference_blob(hb_face), 
        
               harfbuzz.hb_blob_destroy) 
        
           with ffi.new('unsigned int *') as length: 
        
               hb_data = harfbuzz.hb_blob_get_data(hb_blob, length) 
        
               self.file_content = ffi.unpack(hb_data, int(length[0]))

If you have any idea about a way to get here a blob with right variation, that would be very useful!

J-Cake · 2022-08-19T13:50:18Z

Hi @liZe. Thanks for the speedy reply

I'll do some experimentation, and get back to you.
Unfortunately, I don't have to time available right now, but hopefully soon.

I'll keep you posted,
JCake

jthodge · 2022-09-12T17:33:07Z

Also experiencing the same issue as previously outlined by the original poster and other contributors here.

Currently using this workaround as a bandaid — hoping there's a fix in the future, if possible!

tarelda · 2022-09-12T17:41:27Z

Also experiencing the same issue as previously outlined by the original poster and other contributors here.

Currently using this workaround as a bandaid — hoping there's a fix in the future, if possible!

Was about to write exactly the same in the mentioned issue. Something has changed when migrating to pango > 1.44. To be exact everything works up to 52.5. I have bold fonts from exactly the same system-wide installed google ttf's...
Oh someone already found out that year ago #1470 .

liZe · 2022-09-12T18:25:59Z

Something has changed when migrating to pango > 1.44.

The source of the changes is not Pango 1.44 but the removal of Cairo in version 53. We now read and include the fonts ourselves, and it means that we lost some features like variable fonts, font synthesis or bitmap fonts (that’s now fixed).

If anyone knows Harfbuzz and wants to help, that would be very useful!

tarelda · 2022-09-12T18:41:35Z

Something has changed when migrating to pango > 1.44.

The source of the changes is not Pango 1.44 but the removal of Cairo in version 53. We now read and include the fonts ourselves, and it means that we lost some features like variable fonts, font synthesis or bitmap fonts (that’s now fixed).

If anyone knows Harfbuzz and wants to help, that would be very useful!

According to harfbuzz/harfbuzz#2112 and harfbuzz/harfbuzz#3708 something is being done to it, but I have no idea how pinning axis (?!?!?!?!) helps in creating subset font face (!?!!?!?!!) in order to get variable font face.

liZe · 2022-09-17T18:43:35Z

Hi!

If you’re interested in this feature, please try the variable-fonts branch and add a comment to tell what’s working and what’s not! If we get enough answers quickly, it may me included in the next beta version next week.

(You can also try the font-variation-settings attribute that is now supported.)

liZe · 2022-09-22T13:51:35Z

It’s included in version 57 beta (that will be released later today), please test!

tarelda · 2022-09-26T10:09:18Z

Finally had the time to test and in my case all of the required functionalities came back. Big thanks!

@font-face

Version 59.0 ------------ Released on 2023-05-11. This version also includes the changes from unstable b1 version listed below. Bug fixes: * `#1864 <https://github.com/Kozea/WeasyPrint/issues/1864>`_: Handle overflow for svg and symbol tags in SVG images * `#1867 <https://github.com/Kozea/WeasyPrint/pull/1867>`_: Remove duplicate compression of attachments * `d0ad5c1 <https://github.com/Kozea/WeasyPrint/commit/d0ad5c1>`_: Override use tag children instead of drawing their references * `93df1a5 <https://github.com/Kozea/WeasyPrint/commit/93df1a5>`_: Don’t resize the same image twice when the --dpi option is set * `#1874 <https://github.com/Kozea/WeasyPrint/pull/1874>`_: Drawn underline and overline behind text Version 59.0b1 -------------- Released on 2023-04-14. **This version is experimental, don't use it in production. If you find bugs, please report them!** Command-line API: * The ``--optimize-size`` option and its short equivalent ``-O`` have been deprecated. To activate or deactivate different size optimizations, you can now use: * ``--uncompressed-pdf``, * ``--optimize-images``, * ``--full-fonts``, * ``--hinting``, * ``--dpi <resolution>``, and * ``--jpeg-quality <quality>``. * A new ``--cache-folder <folder>`` option has been added to store temporary data in the given folder on the disk instead of keeping them in memory. Python API: * Global rendering options are now given in ``**options`` instead of dedicated parameters, with slightly different names. It means that the signature of the ``HTML.render()``, ``HTML.write_pdf()`` and ``Document.write_pdf()`` has changed. Here are the steps to port your Python code to v59.0: 1. Use named parameters for these functions, not positioned parameters. 2. Rename some the parameters: * ``image_cache`` becomes ``cache`` (see below), * ``identifier`` becomes ``pdf_identifier``, * ``variant`` becomes ``pdf_variant``, * ``version`` becomes ``pdf_version``, * ``forms`` becomes ``pdf_forms``. * The ``optimize_size`` parameter of ``HTML.render()``, ``HTML.write_pdf()`` and ``Document()`` has been removed and will be ignored. You can now use the ``uncompressed_pdf``, ``full_fonts``, ``hinting``, ``dpi`` and ``jpeg_quality`` parameters that are included in ``**options``. * The ``cache`` parameter can be included in ``**options`` to replace ``image_cache``. If it is a dictionary, this dictionary will be used to store temporary data in memory, and can be even shared between multiple documents. If it’s a folder Path or string, WeasyPrint stores temporary data in the given temporary folder on disk instead of keeping them in memory. New features: * `#1853 <https://github.com/Kozea/WeasyPrint/pull/1853>`_, `#1854 <https://github.com/Kozea/WeasyPrint/issues/1854>`_: Reduce PDF size, with financial support from Code & Co. * `#1824 <https://github.com/Kozea/WeasyPrint/issues/1824>`_, `#1829 <https://github.com/Kozea/WeasyPrint/pull/1829>`_: Reduce memory use for images * `#1858 <https://github.com/Kozea/WeasyPrint/issues/1858>`_: Add an option to keep hinting information in embedded fonts Bug fixes: * `#1855 <https://github.com/Kozea/WeasyPrint/issues/1855>`_: Fix position of emojis in justified text * `#1852 <https://github.com/Kozea/WeasyPrint/issues/1852>`_: Don’t crash when line can be split before trailing spaces * `#1843 <https://github.com/Kozea/WeasyPrint/issues/1843>`_: Fix syntax of dates in metadata * `#1827 <https://github.com/Kozea/WeasyPrint/issues/1827>`_, `#1832 <https://github.com/Kozea/WeasyPrint/pull/1832>`_: Fix word-spacing problems with nested tags Documentation: * `#1841 <https://github.com/Kozea/WeasyPrint/issues/1841>`_: Add a paragraph about unsupported calc() function Version 58.1 ------------ Released on 2023-03-07. Bug fixes: * `#1815 <https://github.com/Kozea/WeasyPrint/issues/1815>`_: Fix bookmarks coordinates * `#1822 <https://github.com/Kozea/WeasyPrint/issues/1822>`_, `#1823 <https://github.com/Kozea/WeasyPrint/pull/1823>`_: Fix vertical positioning for absolute replaced elements Documentation: * `#1814 <https://github.com/Kozea/WeasyPrint/pull/1814>`_: Fix broken link pointing to samples Version 58.0 ------------ Released on 2023-02-17. This version also includes the changes from unstable b1 version listed below. Bug fixes: * `#1807 <https://github.com/Kozea/WeasyPrint/issues/1807>`_: Don’t crash when out-of-flow box is split in out-of-flow parent * `#1806 <https://github.com/Kozea/WeasyPrint/issues/1806>`_: Don’t crash when fixed elements aren’t displayed yet in aborted line * `#1809 <https://github.com/Kozea/WeasyPrint/issues/1809>`_: Fix background drawing for out-of-the-page transformed boxes Version 58.0b1 -------------- Released on 2023-02-03. **This version is experimental, don't use it in production. If you find bugs, please report them!** New features: * `#61 <https://github.com/Kozea/WeasyPrint/issues/61>`_, `#1796 <https://github.com/Kozea/WeasyPrint/pull/1796>`_: Support PDF forms, with financial support from Personalkollen * `#1173 <https://github.com/Kozea/WeasyPrint/issues/1173>`_: Add style for form fields Bug fixes: * `#1777 <https://github.com/Kozea/WeasyPrint/issues/1777>`_: Detect JPEG/MPO images as normal JPEG files * `#1771 <https://github.com/Kozea/WeasyPrint/pull/1771>`_: Improve SVG gradients Version 57.2 ------------ Released on 2022-12-23. Bug fixes: * `0f2e377 <https://github.com/Kozea/WeasyPrint/commit/0f2e377>`_: Print annotations with PDF/A * `0e9426f <https://github.com/Kozea/WeasyPrint/commit/0e9426f>`_: Hide annotations with PDF/UA * `#1764 <https://github.com/Kozea/WeasyPrint/issues/1764>`_: Use reference instead of stream for annotation appearance stream * `#1783 <https://github.com/Kozea/WeasyPrint/pull/1783>`_: Fix multiple font weights for @font-face declarations Version 57.1 ------------ Released on 2022-11-04. Dependencies: * `#1754 <https://github.com/Kozea/WeasyPrint/pull/1754>`_: Pillow 9.1.0 is now needed Bug fixes: * `#1756 <https://github.com/Kozea/WeasyPrint/pull/1756>`_: Fix rem font size for SVG images * `#1755 <https://github.com/Kozea/WeasyPrint/issues/1755>`_: Keep format when transposing images * `#1753 <https://github.com/Kozea/WeasyPrint/issues/1753>`_: Don’t use deprecated ``read_text`` function when ``files`` is available * `#1741 <https://github.com/Kozea/WeasyPrint/issues/1741>`_: Generate better manpage * `#1747 <https://github.com/Kozea/WeasyPrint/issues/1747>`_: Correctly set target counters in pages’ absolute elements * `#1748 <https://github.com/Kozea/WeasyPrint/issues/1748>`_: Always set font size when font is changed in line * `2b05137 <https://github.com/Kozea/WeasyPrint/commit/2b05137>`_: Fix stability of font identifiers Documentation: * `#1750 <https://github.com/Kozea/WeasyPrint/pull/1750>`_: Fix documentation spelling Version 57.0 ------------ Released on 2022-10-18. This version also includes the changes from unstable b1 version listed below. New features: * `a4fc7a1 <https://github.com/Kozea/WeasyPrint/commit/a4fc7a1>`_: Support image-orientation Bug fixes: * `#1739 <https://github.com/Kozea/WeasyPrint/issues/1739>`_: Set baseline on all flex containers * `#1740 <https://github.com/Kozea/WeasyPrint/issues/1740>`_: Don’t crash when currentColor is set on root svg tag * `#1718 <https://github.com/Kozea/WeasyPrint/issues/1718>`_: Don’t crash with empty bitmap glyphs * `#1736 <https://github.com/Kozea/WeasyPrint/issues/1736>`_: Always use the font’s vector variant when possible * `eef8b4d <https://github.com/Kozea/WeasyPrint/commit/eef8b4d>`_: Always set color and state before drawing * `#1662 <https://github.com/Kozea/WeasyPrint/issues/1662>`_: Use a stable key to store stream fonts * `#1733 <https://github.com/Kozea/WeasyPrint/issues/1733>`_: Don’t remove attachments when adding internal anchors * `3c4fa50 <https://github.com/Kozea/WeasyPrint/commit/3c4fa50>`_, `c215697 <https://github.com/Kozea/WeasyPrint/commit/c215697>`_, `d275dac <https://github.com/Kozea/WeasyPrint/commit/d275dac>`_, `b04bfff <https://github.com/Kozea/WeasyPrint/commit/b04bfff>`_: Fix many bugs related to PDF/UA structure Performance: * `dfccf1b <https://github.com/Kozea/WeasyPrint/commit/dfccf1b>`_: Use faces as fonts dictionary keys * `0dc12b6 <https://github.com/Kozea/WeasyPrint/commit/0dc12b6>`_: Cache add_font to avoid calling get_face too often * `75e17bf <https://github.com/Kozea/WeasyPrint/commit/75e17bf>`_: Don’t call process_whitespace twice on many children * `498d3e1 <https://github.com/Kozea/WeasyPrint/commit/498d3e1>`_: Optimize __missing__ functions Documentation: * `863b3d6 <https://github.com/Kozea/WeasyPrint/commit/863b3d6>`_: Update documentation of installation on macOS with Homebrew Version 57.0b1 -------------- Released on 2022-09-22. **This version is experimental, don't use it in production. If you find bugs, please report them!** New features: * `#1704 <https://github.com/Kozea/WeasyPrint/pull/1704>`_: Support PDF/UA, with financial support from Novareto * `#1454 <https://github.com/Kozea/WeasyPrint/issues/1454>`_: Support variable fonts Bug fixes: * `#1058 <https://github.com/Kozea/WeasyPrint/issues/1058>`_: Fix bullet position after page break, with financial support from OpenZeppelin * `#1707 <https://github.com/Kozea/WeasyPrint/issues/1707>`_: Fix footnote positioning in multicolumn layout, with financial support from Code & Co. * `#1722 <https://github.com/Kozea/WeasyPrint/issues/1722>`_: Handle skew transformation with only one parameter * `#1715 <https://github.com/Kozea/WeasyPrint/issues/1715>`_: Don’t crash when images are truncated * `#1697 <https://github.com/Kozea/WeasyPrint/issues/1697>`_: Don’t crash when attr() is used in text-decoration-color * `#1695 <https://github.com/Kozea/WeasyPrint/pull/1695>`_: Include language information in PDF metadata * `#1612 <https://github.com/Kozea/WeasyPrint/issues/1612>`_: Don’t lowercase letters when capitalizing text * `#1700 <https://github.com/Kozea/WeasyPrint/issues/1700>`_: Fix crash when rendering footnote with repagination * `#1667 <https://github.com/Kozea/WeasyPrint/issues/1667>`_: Follow EXIF metadata for image rotation * `#1669 <https://github.com/Kozea/WeasyPrint/issues/1669>`_: Take care of floats when remvoving placeholders * `#1638 <https://github.com/Kozea/WeasyPrint/issues/1638>`_: Use the original box when breaking waiting children

grewn0uille added the bug Existing features not working as expected label Sep 28, 2021

liZe mentioned this issue Oct 4, 2021

Performance issue on v53 with large font #1457

Closed

liZe mentioned this issue Oct 12, 2021

Font synthesis (bold, oblique…) no longer works #1470

Open

liZe added this to the 55.0 milestone Dec 11, 2021

grewn0uille removed this from the 55.0 milestone Mar 31, 2022

liZe added this to the 57.0 milestone Sep 22, 2022

liZe closed this as completed Sep 22, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fonts with variable weight don’t work #1454

Fonts with variable weight don’t work #1454

grewn0uille commented Sep 28, 2021

mahiki commented Oct 2, 2021

liZe commented Oct 4, 2021 •

edited

Loading

aschmitz commented Dec 12, 2021

J-Cake commented Aug 19, 2022

liZe commented Aug 19, 2022

J-Cake commented Aug 19, 2022 •

edited

Loading

jthodge commented Sep 12, 2022

tarelda commented Sep 12, 2022 •

edited

Loading

liZe commented Sep 12, 2022

tarelda commented Sep 12, 2022

liZe commented Sep 17, 2022

liZe commented Sep 22, 2022

tarelda commented Sep 26, 2022

Fonts with variable weight don’t work #1454

Fonts with variable weight don’t work #1454

Comments

grewn0uille commented Sep 28, 2021

mahiki commented Oct 2, 2021

liZe commented Oct 4, 2021 • edited Loading

aschmitz commented Dec 12, 2021

J-Cake commented Aug 19, 2022

liZe commented Aug 19, 2022

J-Cake commented Aug 19, 2022 • edited Loading

jthodge commented Sep 12, 2022

tarelda commented Sep 12, 2022 • edited Loading

liZe commented Sep 12, 2022

tarelda commented Sep 12, 2022

liZe commented Sep 17, 2022

liZe commented Sep 22, 2022

tarelda commented Sep 26, 2022

liZe commented Oct 4, 2021 •

edited

Loading

J-Cake commented Aug 19, 2022 •

edited

Loading

tarelda commented Sep 12, 2022 •

edited

Loading