Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for row-gap and gap properties in flex layout #1665

Open
kian-supportinglines opened this issue Jun 28, 2022 · 3 comments
Open
Labels
feature New feature that should be supported

Comments

@kian-supportinglines
Copy link

As of #60 being fixed, we have had support for the column-gap property; I think we should also add in row-gap and gap properties. I can maybe take a look later to see how much work it would be to implement this myself, but I think it might not be so easy. Perhaps we can use the PR linked in #60 to help?

@liZe
Copy link
Member

liZe commented Jul 1, 2022

Hi!

Having column-gap supported for multi-column layout is only the first step. row-gap and gap work on very different environments (flex, grid…) and require a lot of changes to be handled correctly.

@liZe liZe added the feature New feature that should be supported label Jul 1, 2022
@liZe
Copy link
Member

liZe commented May 29, 2024

*-gap and gap are now supported for grid and multi-column layouts.

We have to rewrite the flex layout, we’ll include the support of gap then.

@benjaminuggla
Copy link

benjaminuggla commented May 30, 2024

A simple way to work around this until flex support is fixed:

.item:first-child {
    margin: 0 4px 0 0;
}

.item:last-child {
    margin: 0 0 0 4px;
}

.item:first-child:last-child {
    margin: 0 0 0 0;
}

It's basically doing the same thing as gap.

@liZe liZe changed the title Add support for row-gap and gap properties Add support for row-gap and gap properties in flex layout Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature that should be supported
Projects
None yet
Development

No branches or pull requests

3 participants