Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can not save attached files in Acrobat Reader #2064

Closed
kesara opened this issue Feb 12, 2024 · 3 comments
Closed

Can not save attached files in Acrobat Reader #2064

kesara opened this issue Feb 12, 2024 · 3 comments
Labels
bug Existing features not working as expected
Milestone
61.0

Comments

@kesara
Copy link
Contributor

kesara commented Feb 12, 2024 •
edited
Loading

This issue is in the current main branch (8aecf3853490d271115acf7fe271a43897651644) not in 60.2.
So probably introduced with #1869.

The issue is Adobe Acrobat Reader (version: 2023.008.20470) cannot save attachments from PDFs generated from the main branch.
Acrobat Reader shows the attachments but when you select Save attachment nothing happens.
This functionality works fine for PDFs generated with 60.2.

Acrobat Reader also does not show the file size for attachments of PDFs created with the main branch while it does for 60.2.

With Poppler's pdfdetach, I can save the attached files from PDFs generated with both 60.2 and main branch.

Example

Command:

weasyprint foobar.html foobar.pdf

foobar.html:

<!DOCTYPE html>
<html lang="en">
<head>
    <meta charset="UTF-8">
    <title>Foobar</title>
    <link href="foobar.xml", rel="attachment", type="application/xml", title="source" />
</head>
<body>
    <h1>Hello, World!</h1>
</body>
</html>

foobar.xml:

<?xml version="1.0" encoding="UTF-8"?>
<root>
  <foobar />
</root>
@kesara kesara changed the title Can not save attached files in Acrobat Rader Can not save attached files in Acrobat Reader Feb 12, 2024
@liZe
Copy link
Member

liZe commented Feb 12, 2024

Hi!

Thanks for the report. Is this bug fixed by #2063?

@liZe liZe closed this as completed in 586998e Feb 12, 2024
@liZe liZe added this to the 61.0 milestone Feb 12, 2024
@liZe liZe added the bug Existing features not working as expected label Feb 12, 2024
@kesara
Copy link
Contributor Author

kesara commented Feb 12, 2024

586998e fixed that issue.
Thanks @liZe.

@liZe
Copy link
Member

liZe commented Feb 12, 2024

PDFs with attachments were valid for many libraries and validation tools (including Vera), but they were actually broken according to an online validator. Thanks for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected
Projects
None yet
Milestone
61.0
Development

No branches or pull requests
2 participants
@liZe @kesara