Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Honor the vertical-align property in fixed-height cells #31

Closed
Daisho opened this issue Jan 16, 2013 · 11 comments
Closed

Honor the vertical-align property in fixed-height cells #31

Daisho opened this issue Jan 16, 2013 · 11 comments
Assignees
@liZe
Labels
bug Existing features not working as expected

Comments

@Daisho
Copy link

Daisho commented Jan 16, 2013

inside table cell vertical align is not working
@SimonSapin
Copy link
Member

I haven’t looked into the details yet, but could you be more specific? Please provide an example (HTML and CSS), explain what is the behavior you expected and what you’re getting instead.

@mweissen
Copy link

mweissen commented May 4, 2013

I have tried

<style type="text/css"> td {height: 50px} </style>

But the heigth of the cells did not change.

@liZe
Copy link
Member

liZe commented Dec 30, 2013

Here's a simple example now that heights are handled for tables:
<body><table><tr><td style="background: red; height: 100px; vertical-align: bottom">aaa

@ewjoachim
Copy link

Having the same problem here... If there's at least a workaround, that would be great !

@SimonSapin
Copy link
Member

@ewjoachim Could you give details on what problem exactly you’re having? Please provide an example (HTML and CSS), explain what is the behavior you expected and what you’re getting instead.

@ewjoachim
Copy link

HTML code :

<!DOCTYPE html>
<html>
    <head>
        <meta charset="utf-8" />
        <title></title>
        <style type="text/css">
            td
            {
                height: 50px;
                border: 1px solid red;
                vertical-align: bottom;
            }
        </style>
    </head>

    <body>
        <table>
            <tr><td>Yay</td></tr>
        </table>
    </body>
</html>

(no CSS other than inlined)

Expected : "Yay" should be at the bottom of the cell
What I get instead : "Yay" is at the top (whatever the value of vertical-align)
(maybe my HTML is wrong in the first place, all I can tell is that both Chorme and Firefox got it right)

@s31415 s31415 mentioned this issue Aug 29, 2014
Closed
@honi
Copy link

honi commented Jan 16, 2015

Having the same problem here. Does anybody know if @s31415 fix works? Any plan on merging it?

@vojkny
Copy link

vojkny commented Apr 23, 2015

vertical-align: middle; does not work either.

@liZe liZe self-assigned this Apr 23, 2015
@liZe
Copy link
Member

liZe commented Apr 23, 2015

I'll take a look at this

@liZe
Copy link
Member

liZe commented Apr 24, 2015

The patch proposed in #214 works for fixed-height rows, but not for fixed-height cells. I'm trying to find a better solution.

@liZe
Copy link
Member

liZe commented Apr 25, 2015

vertical-align was handled for cells with an auto height (ie. adding padding to make it fit in the row), but it was not handled for cells with a fixed height (ie. changing the position of the content in the cell).

f4f8c25 fixes the main common cases (and doesn't break any test). I'm not sure about many corner cases, including:

  • cells with a vertical-align: baseline property
  • cells with a fixed height and a vertical padding
  • cells in fixed-height rows (what Update tables.py #214 is about)

I'll add some tests and fix the bugs I can find. @honi @knyttl : you are welcome to test and find any case that's not working for you!

@liZe liZe changed the title vertical align Honor the vertical-align property in fixed-height cells Apr 25, 2015
@liZe liZe closed this as completed in 4ed0c3c Apr 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@liZe liZe

Labels
bug Existing features not working as expected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@honi @SimonSapin @vojkny @liZe @Daisho @mweissen @ewjoachim