Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

string-set '' doesn't clear previous value from named string [43rc1 regression] #726

Closed
Smylers opened this issue Nov 1, 2018 · 3 comments
Closed

string-set '' doesn't clear previous value from named string [43rc1 regression] #726

Smylers opened this issue Nov 1, 2018 · 3 comments
Labels
bug Existing features not working as expected
Milestone
43

Comments

@Smylers
Copy link
Contributor

Smylers commented Nov 1, 2018

string-set: foo '' used to clear the named string. It now seems to be ignored, leaving the previous value in there.

Demo:

<!DOCTYPE html>
<title>Clear String Check</title>
<style>
@page { @top-left  { content: '[' string(left) ']' } }
p { page-break-before: always }
.initial { -weasy-string-set: left 'initial' }
.empty   { -weasy-string-set: left ''        }
.space   { -weasy-string-set: left ' '       }
</style>

<p class=initial>Initial
<p class=empty  >Empty
<p class=space  >Space

In WeasyPrint 0.39, the three page headings are the expected “[initial]”, “[]”, and “[ ]”. But in 43rc1, the middle one is still “[initial]”.
@Tontyna
Copy link
Contributor

Tontyna commented Nov 1, 2018 •
edited
Loading

reason is if text: condition in build.py in line 403 and line 297

@liZe any bad side-effects expected when changed to if len(tests) > 0: ?

@liZe
Copy link
Member

liZe commented Nov 2, 2018

Oops, forgot this issue.

@liZe any bad side-effects expected when changed to if len(tests) > 0: ?

Probably not, I'll change this.

@liZe liZe closed this as completed in 3ca9941 Nov 2, 2018
@liZe
Copy link
Member

liZe commented Nov 2, 2018

Probably not, I'll change this.

It actually was a bit more complicated than this, as compute_content_list has to return something when the string is empty, but empty text boxes are not allowed.

I used None when nothing has been found and [] when something has been found but didn't create a box.

@liZe liZe added bug Existing features not working as expected regression labels Nov 2, 2018
@liZe liZe added this to the 43 milestone Nov 2, 2018
netbsd-srcmastr referenced this issue in NetBSD/pkgsrc Nov 14, 2018
@kleink
py-weasyprint: Update to 43.
c51d0b2 
Version 43
----------

Released on 2018-11-09.

Bug fixes:

* `#726 <https://github.com/Kozea/WeasyPrint/issues/726>`_:
  Make empty strings clear previous values of named strings
* `#729 <https://github.com/Kozea/WeasyPrint/issues/729>`_:
  Include tools in packaging

This version also includes the changes from unstable rc1 and rc2 versions
listed below.

Version 43rc2
-------------

Released on 2018-11-02.

**This version is experimental, don't use it in production. If you find bugs,
please report them!**

Bug fixes:

* `#706 <https://github.com/Kozea/WeasyPrint/issues/706>`_:
  Fix text-indent at the beginning of a page
* `#687 <https://github.com/Kozea/WeasyPrint/issues/687>`_:
  Allow query strings in file:// URIs
* `#720 <https://github.com/Kozea/WeasyPrint/issues/720>`_:
  Optimize minimum size calculation of long inline elements
* `#717 <https://github.com/Kozea/WeasyPrint/issues/717>`_:
  Display <details> tags as blocks
* `#691 <https://github.com/Kozea/WeasyPrint/issues/691>`_:
  Don't recalculate max content widths when distributing extra space for tables
* `#722 <https://github.com/Kozea/WeasyPrint/issues/722>`_:
  Fix bookmarks and strings set on images
* `#723 <https://github.com/Kozea/WeasyPrint/issues/723>`_:
  Warn users when string() is not used in page margin


Version 43rc1
-------------

Released on 2018-10-15.

**This version is experimental, don't use it in production. If you find bugs,
please report them!**

Dependencies:

* Python 3.4+ is now needed, Python 2.x is not supported anymore
* Cairo 1.15.4+ is now needed, but 1.10+ should work with missing features
  (such as links, outlines and metadata)
* Pdfrw is not needed anymore

New features:

* `Beautiful website <https://weasyprint.org>`_
* `#579 <https://github.com/Kozea/WeasyPrint/issues/579>`_:
  Initial support of flexbox
* `#592 <https://github.com/Kozea/WeasyPrint/pull/592>`_:
  Support @font-face on Windows
* `#306 <https://github.com/Kozea/WeasyPrint/issues/306>`_:
  Add a timeout parameter to the URL fetcher functions
* `#594 <https://github.com/Kozea/WeasyPrint/pull/594>`_:
  Split tests using modern pytest features
* `#599 <https://github.com/Kozea/WeasyPrint/pull/599>`_:
  Make tests pass on Windows
* `#604 <https://github.com/Kozea/WeasyPrint/pull/604>`_:
  Handle target counters and target texts
* `#631 <https://github.com/Kozea/WeasyPrint/pull/631>`_:
  Enable counter-increment and counter-reset in page context
* `#622 <https://github.com/Kozea/WeasyPrint/issues/622>`_:
  Allow pathlib.Path objects for HTML, CSS and Attachment classes
* `#674 <https://github.com/Kozea/WeasyPrint/issues/674>`_:
  Add extensive installation instructions for Windows

Bug fixes:

* `#558 <https://github.com/Kozea/WeasyPrint/issues/558>`_:
  Fix attachments
* `#565 <https://github.com/Kozea/WeasyPrint/issues/565>`_,
  `#596 <https://github.com/Kozea/WeasyPrint/issues/596>`_,
  `#539 <https://github.com/Kozea/WeasyPrint/issues/539>`_:
  Fix many PDF rendering, printing and compatibility problems
* `#614 <https://github.com/Kozea/WeasyPrint/issues/614>`_:
  Avoid crashes and endless loops caused by a Pango bug
* `#662 <https://github.com/Kozea/WeasyPrint/pull/662>`_:
  Fix warnings and errors when generating documentation
* `#666 <https://github.com/Kozea/WeasyPrint/issues/666>`_,
  `#685 <https://github.com/Kozea/WeasyPrint/issues/685>`_:
  Fix many table layout rendering problems
* `#680 <https://github.com/Kozea/WeasyPrint/pull/680>`_:
  Don't crash when there's no font available
* `#662 <https://github.com/Kozea/WeasyPrint/pull/662>`_:
  Fix support of some align values in tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Existing features not working as expected
Projects
None yet
Milestone
43
Development

No branches or pull requests
3 participants
@Smylers @liZe @Tontyna