Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThumbnailL1 issue? #97

Closed
klous-1 opened this issue Nov 7, 2015 · 6 comments
Closed

ThumbnailL1 issue? #97

klous-1 opened this issue Nov 7, 2015 · 6 comments

Comments

@klous-1
Copy link

klous-1 commented Nov 7, 2015

Hi Christophe,

I'm not sure but it looks to me like there is some issue with thumbnailL1Height/Width. The thumbs are not displaying correctly, just small slits (may depend on settings/sizes used).

I've just updated from v5.4 to 5.9, and then also tried an old jsfiddle of yours which has v5.7. v5.4 is/was working fine, but 5.7 and 5.9 seem to have this issue.

Check out the updated fiddle here which shows the problem:
http://jsfiddle.net/99xLegdk/

@klous-1
Copy link
Author

klous-1 commented Nov 7, 2015

OK, it seems to be a problem with 'auto' option in combination with thumbnailL1 settings....oddly the Level 1 images display okay. Take out auto or L1 setting and it works okay.

@Kris-B
Copy link
Owner

Kris-B commented Nov 9, 2015

Hey! Actually it is an issue with 'auto' and Picasa storage.
The 'auto' value implies the thumbnail image size (width and height) to be known. But the Picasa/Google+ API returns incorrect values for the first level (albums).
So nG needs to wait until the thumbnail images are loaded to retrieve their correct size and then the layout can be rendered.

So long for the method...

I check the fiddle http://jsfiddle.net/99xLegdk/ : I see the small slits and after a small delay, thumbnails are displayed correctly.

In your case : the small slits are never replaced by the correct thumbnails?

@klous-1
Copy link
Author

klous-1 commented Nov 9, 2015

Level1 is okay (albums) but it is the photos within the albums which is the problem....slits remain permanently, in the fiddle too (it's not like this for you?).

Like I say, v5.4 was no problem and my gallery is fine with this version, so something has changed.(http://www.talesfromthesaddle.com/photos)

@Kris-B
Copy link
Owner

Kris-B commented Nov 18, 2015

ok, found this issue.
please check v5.9.1

@klous-1
Copy link
Author

klous-1 commented Nov 28, 2015

Thanks Christophe! Works a treat now! 👍

@Kris-B
Copy link
Owner

Kris-B commented Nov 28, 2015

;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants