Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert StandardLogfile loglevels properties to extension methods #4

Open
KristianVirkus opened this issue Jul 12, 2019 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@KristianVirkus
Copy link
Owner

Currently the StandardLogfile contains properties to easily and fluently get new log event instances by loglevel. Unfortunately, as soon as the StandardLogfile instance is handed over as ILogfileProxy<StandardLoglevel> these properties are no longer accessible.
These properties should be replaced in favor of extension methods on ILogfileProxy<StandardLoglevel> eventhough it's a slight loss of fluent syntax as paranthesis are required to get a new log event instance. Maybe it's even cleaner that way.
As an alternative, extension properties could be introduced as soon as they become available (see dotnet/roslyn#11159).

@KristianVirkus KristianVirkus added the enhancement New feature or request label Jul 12, 2019
@KristianVirkus KristianVirkus changed the title Make StandardLogfile properties for loglevels extension methods Convert StandardLogfile loglevels properties to extension methods Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant