Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prettytime limit for switching from seconds to minutes #148

Closed
jaakkor2 opened this issue May 2, 2022 · 2 comments · Fixed by #151
Closed

prettytime limit for switching from seconds to minutes #148

jaakkor2 opened this issue May 2, 2022 · 2 comments · Fixed by #151

Comments

@jaakkor2
Copy link

jaakkor2 commented May 2, 2022

#146 added minute and hour for elapsed time units. Switching from seconds to minutes at 60 seconds is too early in my opinionated view.

As an example, consider this example

────────────────────────────────────
                   Time             
          ───────────────────────   
               2.82m /  99.4%       
                                    
  ncalls     time    %tot     avg   
────────────────────────────────────
       1    1.16m   41.6%   1.16m   
       1    44.3s   26.4%   44.3s   
       1    25.1s   14.9%   25.1s   
       1    6.83s    4.1%   6.83s   

1.16m is about 70 s, 2.82m is about 169 s, for these small numbers writing the elapsed time in seconds would be clearer (for me, at least). Maybe the limit for the transition from seconds to minutes could be 500 s ? I tried a quick internet search, but that did not return any good advice.

Also, symbol m for minute is a bit obscure. https://physics.nist.gov/cuu/Units/outside.html defines the symbol of minute as min.

@KristofferC
Copy link
Owner

Yeah, I agree. 1.16m does not look nice at all. I think the motivation in #146 was for very long times. I'm ok with just skipping minutes completely and go over to hours when time > 3600 s. What do you think about that?

@jaakkor2
Copy link
Author

jaakkor2 commented May 2, 2022

Yeah, I agree. 1.16m does not look nice at all. I think the motivation in #146 was for very long times. I'm ok with just skipping minutes completely and go over to hours when time > 3600 s. What do you think about that?

Sounds good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants