Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use table name from config in migrations #243

Closed
Lotuashvili opened this issue Dec 3, 2023 · 2 comments · Fixed by #247
Closed

Use table name from config in migrations #243

Lotuashvili opened this issue Dec 3, 2023 · 2 comments · Fixed by #247
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Lotuashvili
Copy link
Contributor

In the current migration add_theme_support_level_to_users_table the table users is being used directly. It should be Util::getShopsTable().

https://github.com/Kyon147/laravel-shopify/blob/master/src/resources/database/migrations/2022_06_09_104819_add_theme_support_level_to_users_table.php

image
@Lotuashvili Lotuashvili added bug Something isn't working unconfirmed Bug has not been reproduced yet labels Dec 3, 2023
@Kyon147
Copy link
Owner

Kyon147 commented Dec 6, 2023

Good catch, could you open a PR?

@Kyon147 Kyon147 added help wanted Extra attention is needed good first issue Good for newcomers and removed unconfirmed Bug has not been reproduced yet labels Dec 6, 2023
@Lotuashvili Lotuashvili mentioned this issue Dec 6, 2023
Merged
@Lotuashvili
Copy link
Contributor Author

@Kyon147 There you go :) #247

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace hardcoded table name with helper method Lotuashvili/laravel-shopify
2 participants
@Lotuashvili @Kyon147