Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible test failure in upcoming Julia version 1.5 #155

Closed
rfourquet opened this issue Apr 24, 2020 · 1 comment
Closed

possible test failure in upcoming Julia version 1.5 #155

rfourquet opened this issue Apr 24, 2020 · 1 comment

Comments

@rfourquet
Copy link

A PkgEval run for a PR which changes the generated numbers for randn! indicates that the tests of this package might fail in Julia 1.5 (and on Julia current master). Apologies if this is a false positive.
cf. https://github.com/JuliaCI/NanosoldierReports/blob/7de24e455342298cbef56826b5827f0d7640d2c1/pkgeval/by_hash/b89e35c_vs_098ef24/logs/StateSpaceModels/1.5.0-DEV-71a4a114c2.log

@raphaelsaavedra
Copy link
Member

Hi @rfourquet,

Thanks for the heads up. This is a good reminder to us that we are a little late in our CI checks. We are currently testing only up to 1.3, we definitely should be testing 1.4 and nightly (allowing failures on nightly).

That error also shows that our tests are not that robust if they are depending on a certain seed :) We will look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants