From cc20bf31fe7ab94418d925922825f8a5404a3794 Mon Sep 17 00:00:00 2001 From: Sanjeet Suhag Date: Mon, 29 Jun 2020 16:03:32 -0400 Subject: [PATCH 1/5] Fixes ScreenSpaceEventHandler.getInputAction JSDoc --- Source/Core/ScreenSpaceEventHandler.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Source/Core/ScreenSpaceEventHandler.js b/Source/Core/ScreenSpaceEventHandler.js index db52177dc029..ce209cef9732 100644 --- a/Source/Core/ScreenSpaceEventHandler.js +++ b/Source/Core/ScreenSpaceEventHandler.js @@ -969,6 +969,8 @@ ScreenSpaceEventHandler.prototype.setInputAction = function ( * @param {Number} [modifier] A KeyboardEventModifier key that is held when a type * event occurs. * + * @returns {Function} The function to be executed on an input event. + * * @see ScreenSpaceEventHandler#setInputAction * @see ScreenSpaceEventHandler#removeInputAction */ From a633073f66063e2826170b19d5dd9768155ce878 Mon Sep 17 00:00:00 2001 From: Sanjeet Suhag Date: Mon, 29 Jun 2020 16:09:52 -0400 Subject: [PATCH 2/5] Updates CHANGES.md --- CHANGES.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGES.md b/CHANGES.md index 46ba74d58f94..04c843fd23b3 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -26,6 +26,7 @@ - Fixed a bug where switching to orthographic camera on the first frame caused the zoom level to be incorrect. [#8853](https://github.com/CesiumGS/cesium/pull/8853) - Fixed `scene.pickFromRay` intersection inaccuracies. [#8439](https://github.com/CesiumGS/cesium/issues/8439) - Fixed a bug where a null or undefined name property passed to the `Entity` constructor would throw an exception.[#8832](https://github.com/CesiumGS/cesium/pull/8832) +- Fixed JSDoc and TypeScript type definitions for `ScreenSpaceEventHandler.getInputAction` which listen incorrect return type.[#9002](https://github.com/CesiumGS/cesium/pull/9002) ### 1.70.1 - 2020-06-10 From 0b335a10d767138d45f4c2004ec7443472c7e9b3 Mon Sep 17 00:00:00 2001 From: Sanjeet Suhag Date: Mon, 29 Jun 2020 16:10:42 -0400 Subject: [PATCH 3/5] Fixes typo in CHANGES.md --- CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index 04c843fd23b3..99f237856ae6 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -26,7 +26,7 @@ - Fixed a bug where switching to orthographic camera on the first frame caused the zoom level to be incorrect. [#8853](https://github.com/CesiumGS/cesium/pull/8853) - Fixed `scene.pickFromRay` intersection inaccuracies. [#8439](https://github.com/CesiumGS/cesium/issues/8439) - Fixed a bug where a null or undefined name property passed to the `Entity` constructor would throw an exception.[#8832](https://github.com/CesiumGS/cesium/pull/8832) -- Fixed JSDoc and TypeScript type definitions for `ScreenSpaceEventHandler.getInputAction` which listen incorrect return type.[#9002](https://github.com/CesiumGS/cesium/pull/9002) +- Fixed JSDoc and TypeScript type definitions for `ScreenSpaceEventHandler.getInputAction` which listed incorrect return type. [#9002](https://github.com/CesiumGS/cesium/pull/9002) ### 1.70.1 - 2020-06-10 From 4c9381180a84192c60957a804385af07264c7199 Mon Sep 17 00:00:00 2001 From: Sanjeet Suhag Date: Mon, 29 Jun 2020 17:09:11 -0400 Subject: [PATCH 4/5] Fixes typos in CHANGES.md --- CHANGES.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 99f237856ae6..ff20701feb58 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -4,7 +4,7 @@ ##### Breaking Changes :mega: -- Updated `WallGeometry` to respect the order of positions passed in, instead of making the positions respect a counter clockwise winding order. This will only effect the look of walls with an image material. If this changed the way your wall is drawing, reverse the order of the positions. +- Updated `WallGeometry` to respect the order of positions passed in, instead of making the positions respect a counter clockwise winding order. This will only effect the look of walls with an image material. If this changed the way your wall is drawing, reverse the order of the positions. [#8955](https://github.com/CesiumGS/cesium/pull/8955/) ##### Additions :tada: @@ -15,13 +15,13 @@ ##### Fixes :wrench: -- Fixed issue where tileset was not playing glTF animations [#8962](https://github.com/CesiumGS/cesium/issues/8962) +- Fixed issue where tileset was not playing glTF animations. [#8962](https://github.com/CesiumGS/cesium/issues/8962) - Fixed a divide-by-zero bug in `Ellipsoid.geodeticSurfaceNormal` when given the origin as input. `undefined` is returned instead. [#8986](https://github.com/CesiumGS/cesium/pull/8986) -- Fixed error with `WallGeoemtry` when there were adjacent positions with very close values [#8952](https://github.com/CesiumGS/cesium/pull/8952) +- Fixed error with `WallGeoemtry` when there were adjacent positions with very close values. [#8952](https://github.com/CesiumGS/cesium/pull/8952) - Fixed artifact for skinned model when log depth is enabled. [#6447](https://github.com/CesiumGS/cesium/issues/6447) - Fixed a bug where certain rhumb arc polylines would lead to a crash. [#8787](https://github.com/CesiumGS/cesium/pull/8787) - Fixed handling of Label's backgroundColor and backgroundPadding option [#8949](https://github.com/CesiumGS/cesium/8949) -- Fixed several bugs when rendering CesiumJS in a WebG 2 context. [#797](https://github.com/CesiumGS/cesium/issues/797) +- Fixed several bugs when rendering CesiumJS in a WebGL 2 context. [#797](https://github.com/CesiumGS/cesium/issues/797) - Fixed a bug where switching from perspective to orthographic caused triangles to overlap each other incorrectly. [#8346](https://github.com/CesiumGS/cesium/issues/8346) - Fixed a bug where switching to orthographic camera on the first frame caused the zoom level to be incorrect. [#8853](https://github.com/CesiumGS/cesium/pull/8853) - Fixed `scene.pickFromRay` intersection inaccuracies. [#8439](https://github.com/CesiumGS/cesium/issues/8439) From 09cbbd403a18a3fdf4bd71a8a9fd39ce8dc35872 Mon Sep 17 00:00:00 2001 From: Sanjeet Suhag Date: Mon, 29 Jun 2020 17:16:12 -0400 Subject: [PATCH 5/5] Fixes typo in CHANGES.md --- CHANGES.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGES.md b/CHANGES.md index ff20701feb58..79503980af73 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -4,7 +4,7 @@ ##### Breaking Changes :mega: -- Updated `WallGeometry` to respect the order of positions passed in, instead of making the positions respect a counter clockwise winding order. This will only effect the look of walls with an image material. If this changed the way your wall is drawing, reverse the order of the positions. [#8955](https://github.com/CesiumGS/cesium/pull/8955/) +- Updated `WallGeometry` to respect the order of positions passed in, instead of making the positions respect a counter clockwise winding order. This will only affect the look of walls with an image material. If this changed the way your wall is drawing, reverse the order of the positions. [#8955](https://github.com/CesiumGS/cesium/pull/8955/) ##### Additions :tada: