Increase ZASF "Parts Insertion Effects" slots.

[mikobuntu]

at the moment ZynAddSubFX allows only 3 insertion FX . I believe something like 8 would suit a lot of LMMS users better ( i have edited this in my own install ). talking from personal experience when i am creating sounds i like to have subtle FX like chorus, reverb, echo and perhaps an offset delay using 2 delays and then wish to add eq, so i find myself having to use the main ZASF gui to set these extra FX, which in turn slows down workflow. Only 1 number in the code needs changing.
thoughts on this???

[Sti2nd]

Why would they limit the effects to just 3... that is strange, or has a good reason 🐝

[mikobuntu]

"Why would they limit the effects to just 3... that is strange, or has a good reason "
I'm unsure, might be a good idea to ask on their git , tho there are plenty of system and insertion effects in the advanced mode main gui window, i rarely touch these and most presets i have looked at seem to rarely use them either.
maybe because no one has requested they be increased, no one has thought the need to do so.

[musikBear]

you mean 'System-effects' Only 3 'System-effects'. ?
The 0.92 zyn install allows 3 'System-effects' but 7 (1..8) 'insertion-effects' - Im sorry, but i cant remember if the number of 'System-effects' always was 3..
They are different, because 'System-effects' has send-effect, and that may be why only 3 is available, but 092 has 7 insertion-effects. Is Master different?
(There was a zasfx update yesterday by Toby) :
http://linux-multimedia-studio-lmms.996328.n3.nabble.com/new-zasfx-how-is-the-quality-any-aspects-discuss-td9642.html

[mikobuntu]

NO I understand about the number of effects in the main GUI ( when 1st opened ), circled in RED in my image. I'm talking about the "Parts Insertion Effects" circled in GREEN . http://www.anony.ws/image/DLI4 I perhaps should have been more specific when naming my request

thanks Mikobuntu ;)

[musikBear]

Parts..! ahh 🎱
-btw picture causes 404 :)

Uhoh.. If you have older instruments made with >3 effects, what happens then if you load one of those, and how are the shown in the ui? (but you changed code -right? was issues at load the reason?)

[mikobuntu]

@musikBear oops try now, i fixed a typo in the link 🐫 , anyway you have a good point there for compatability purposes, i will make a test install and see how 1 of my instruments with >3 Insertion Parts FX behaves. And btw instruments with =3 FX work fine with my patch so far in testing, they just have 5 more unallocated slots, which can be used if needed.

[mikobuntu]

Please follow and comment etc on my thread here https://sourceforge.net/p/zynaddsubfx/mailman/zynaddsubfx-user/ on the ZASF mailing list thanks Mikobuntu ;)

[mikobuntu]

ok i tested on another install of lmms-stable without my patch and loaded a ZASF preset that i created with 8 Parts Insertion Effects in it and i can confirm that there are no issues. As expected just the 1st 3 effects show up in the GUI and no errors showing in the console.

[diizy]

On 07/18/2014 04:32 PM, Mikobuntu wrote:

ok i tested on another install of lmms-stable without my patch and
loaded a ZASF preset that i created with 8 Parts Insertion Effects in
it and i can confirm that there are no issues. As expected just the
1st 3 effects show up in the GUI and no errors showing in the console.

I think this should be tested in all platforms. If there's no issues in
testing, then the patch can be committed to our lmms/zynaddsubfx
repository https://github.com/LMMS/zynaddsubfx/

[mikobuntu]

"I think this should be tested in all platforms."
"great, now time for you win and even mac ( @tresf ) testers to get testing :)
thanks Mikobuntu ;)

[mikobuntu]

I will create an instrument with all 8 FX slots occupied , save as both native LMMS xpf and ZASF .xiz patches and upload them to my gdrive so that all other OS users can test ....

https://drive.google.com/file/d/0B780anJGotTaNndGcGJFajhLS1U/edit?usp=sharing

https://drive.google.com/file/d/0B780anJGotTaZkdTd0x1RFpWcFk/edit?usp=sharing

these are just a single square wave with all 8 FX slots filled .
I have used eq and in 2 of the latter fx there are reverb and echo, so there is a noticeable difference to the sound if the effects are proccessed.
For me when i use my unpatched version of LMMS neither the extra slots 4-8 are shown, nor do the effects get proccessed. I believe this behaviour to be ok for backward compatability, although if this is implemented any patches made like the ones above the extra effects will not proccess, but i guess this can be compared to having new synths such as SFXR, Monstro etc songs made using these will not be useful to users on older versions of LMMS

[musikBear]

tested 1.092 win32 xp
I can open both, and both plays. When i open the ui and goes to the part-insert-effects, i can only see 3 (none past EQ)
But this is only half of the test. All OS also need to be tested for behavior witl OLD xpf and ZASF .xiz files IF the code is changed to 8 effects - so compiled Masters (including Tobys last zyn update (17 juli)) is needed before we know if the 3->8 change can create grief :)
But first of - no grief

[tresf]

Here are some custom Windows builds 1.0.02_bug1002 to test out the code change on:

Win32:
(link removed)

Win64:
(link removed)

After reading the bug report as well as the Zyn documentation, I'm still not entirely sure what this does within the Zyn plugin. Perhaps a screenshot in the original description may be helpful for users that don't dive into these elements of Zyn all that much.

great, now time for you win and even mac ( @tresf ) testers to get testing :)

If it's OK, I won't be creating or testing against OSX just for this code change since there are many other open stability issues on Apple (such as the Zyn GUI deadlocking the software, SF2 bugs, file association stuff, etc) that I would rather see addressed first. If people disagree I can always fire up the Mac and accommodate this request.

[mikobuntu]

@tresf
great job on creating the windows builds. And i will make a video tutorial with annotations and link to my youtube so users can understand what they are actually testing. And as for the OSX testing, no worries , Its best to take care of the bugs 1st imo.

[musikBear]

Here are some custom Windows builds 1.0.02_bug1002 to test out the code change on

I have tested win32xp for this now
It works perfectly! 🍡
Tested:
mikobuntu's both files loads, and plays all effect-slots
old zasfx presets (willGodfrys) loads and plays. They have 8 part-insert-effects-slots, and if effects are inserted in slot 4..8 they work, and there are no eminent issues
Adding 5 more effect-slots to part-insert-effects, seams to be without issues for 32xp
(Now.. wonder if System-effects (also only 3) could be expanded to 8 as well :P )
Thats not all. Toby upgrade has remeoved the visual glitch on syn-select:
That is now correct:
http://snag.gy/BPt05.jpg
A new check-mark (ring) and better panels (crosses)
Super!
But one thing its not a 1.0.02 build ?? its marked as 1.0.92

[tresf]

Closing as this is not our bug and we're switching to 2.5 shortly via #1860

Please file a bug upstream if needed. 👍