Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illogical controller for level on Calf Equalzer 12 bands ladspa #2052

Closed
musikBear opened this issue May 15, 2015 · 4 comments
Closed

illogical controller for level on Calf Equalzer 12 bands ladspa #2052

musikBear opened this issue May 15, 2015 · 4 comments
Milestone

Comments

@musikBear
Copy link

imo the Level controllers are illogical. They are now calibrated for span ~0..~64, but logically levels for an EQ should be calibrated around 0 - like -32..0..32. This would allow the user to add and subtract from the chosen freq. (just as f.i. in the C*Eq)
Furthermore are the graining for level and gain, much too rough, and could easily be divided with a factor 10 -at least. That would give a much more sane span for the dial(s) -Now they seriously overload at setting ~10 %

@tresf
Copy link
Member

tresf commented May 15, 2015

Can you please take screenshots and illustrate what you are describing?

The code for the EQ is here: https://github.com/LMMS/lmms/blob/master/plugins/LadspaEffect/calf/src/modules_eq.cpp

I don't see anything in the EQ class specifically bound to the range you are describing, so if you can help locate the place in the code that is limiting this range it will make fixing this issue more likely. (perhaps here? calf/src/plugin.cpp#L383

P.S. You can search through the source code using the search bar at the top of this page.

-Tres

@softrabbit
Copy link
Member

No need for screnshots, on Linux you can use analyseplugin to figure out properties of LADSPA plugins, e.g. analyseplugin /usr/lib/i386-linux-gnu/lmms/ladspa/calf.so. Some interesting control ranges for this EQ:

        "Input Gain" input, control, 0 to 64, default 1
        "Output Gain" input, control, 0 to 64, default 1
        "Level L" input, control, 0.015625 to 64, default 1
        "Level H" input, control, 0.015625 to 64, default 1
        "Level 1" input, control, 0.015625 to 64, default 1
        "Q 1" input, control, 0.1 to 100, default 1, logarithmic

@tresf
Copy link
Member

tresf commented May 15, 2015

👍

Looks to be defined here. calf/src/metadata.cpp#L706 Thanks @softrabbit!!

-Tres

@tresf tresf added this to the 1.3.0 milestone May 15, 2015
@SecondFlight
Copy link
Member

As part of a pruning effort, this enhancement request is archived into a dedicated "Better Workflow" checklist here #4877.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants