Crash on exit from rpmalloc assert in debug builds, equalizer plugin related

[sziegler103]

Bug Summary

rpmalloc aborts from an assertion on program exit if the equalizer plugin is added to an FX track.
#5733 might be related, which was thought to be fixed by #5776.

Note: The few other plugins I've tested don't seem to cause this, only equalizer. I haven't tested many other plugins though.

Steps to reproduce

1. Run a debug build of LMMS.
2. Add the equalizer plugin to either the master FX track or a created FX track.
3. Close LMMS via the 'X' button or File -> Quit.

Expected behavior

LMMS closes without aborting preemptively.

Actual behavior

LMMS "crashes" from the assert calling an abort.

Screenshot

Affected LMMS versions

Version 1.3.0-alpha.1.105
Debug configuration.

Unknown if on stable because I don't have the know-how to build and test 1.2.2

Logs

(From console)

Assertion failed: span->list_size == span->used_count, file C:\LMMSDev\lmms\src\3rdparty\rpmalloc\rpmalloc\rpmalloc\rpmalloc.c, line 1248

Note

Probably not a big deal since it happens on program exit, so the OS will (hopefully) clean up anyway, but still something to consider.

[PhysSong]

Reproduced in Linux+GCC debug builds, too.

lmms/plugins/Eq/EqControlsDialog.cpp

Lines 200 to 210 in 877a931

	automatableButtonGroup *lpBtnGrp = new automatableButtonGroup( this, tr( "LP group" ) );
	lpBtnGrp->addButton( lp12Button );
	lpBtnGrp->addButton( lp24Button );
	lpBtnGrp->addButton( lp48Button );
	lpBtnGrp->setModel( &m_controls->m_lpTypeModel, false);
	automatableButtonGroup *hpBtnGrp = new automatableButtonGroup( this, tr( "HP group" ) );
	hpBtnGrp->addButton( hp12Button );
	hpBtnGrp->addButton( hp24Button );
	hpBtnGrp->addButton( hp48Button );
	hpBtnGrp->setModel( &m_controls->m_hpTypeModel,false);

The two setModel calls passes false as the second argument, and this makes the default model constructed in the automatableButtonGroup constructor leaked.