Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements to quantisation in song editor #6420

Closed
Rossmaxx opened this issue May 30, 2022 · 1 comment
Closed

improvements to quantisation in song editor #6420

Rossmaxx opened this issue May 30, 2022 · 1 comment

Comments

@Rossmaxx
Copy link
Contributor

Rossmaxx commented May 30, 2022

Enhancement Summary

We have an option to change the quantisation in song editor in the master, but it is incomplete. The quantization is there but the grid lines do not get edited, unlike the behaviour in the piano roll where changing quantization updates the grid lines.

Justification

The absence of grid lines for quantization makes it harder to place everything at the right grid when the quantization is set to something other than 1 full bar. So the behaviour in piano roll should be brought to song editor. But there is a problem while doing that.

  • the smaller grid lines will be barely visible.
    Solution : fix the zoom level to be 8* the current zoom level. Also, make the main grid (ie 1 bar line) to be a bit thicker than the others as well as make it a bit whiter.

Mockup

snapping concept

This mockup is just a reference for understanding what i mean. It is not 100% accurate.

@Rossmaxx
Copy link
Contributor Author

Fixed in #7034

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant