automation max value changes when loading a saved file

[snorasaur]

Bug Summary

when i make an automation track with points that have values higher than 1, they will be reverted to 1 upon loading

Steps to reproduce

open organic synth
add automation track
drag harmonic dial to automation track (values are 0-17)
lay points on the track varying from 0-17
save file
load file
check automation track. upper limit will be set back to 1.0, and points with values greater than 1 become 1.

Expected behavior

automation points should stay at the number they were assigned. not truncated down to 1.0

Actual behavior

automation points greater than 1.0, become 1.0

Screenshot

Affected LMMS versions

1.2.2

Logs

Click to expand

[snorasaur]

no sound, but u get the idea.

https://youtu.be/0dfKMKUdcWU

[messmerd]

I've confirmed that this bug is present in the master branch.

[messmerd]

I have a good idea about what is causing this issue and I'm just figuring out how I should fix it. Interestingly, it looks like Organic synth is not the only instrument exhibiting this bug - Kicker's end distortion parameter does the same thing.

I'll try to fix all instances of this bug within the next couple days. EDIT: Or tonight haha

[snorasaur]

thanks for the quick fix!

[messmerd]

@snorasaur The PR with the fix hasn't been approved and merged into master yet, so you should keep this issue open until that happens. Usually issues are automatically marked as completed when the PR linked to them is completed and merged.