-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable LADSPA plugins on MSVC #6973
Conversation
This reverts commit 5fb6fba.
I've only asked for basic regression testing. :). If you guys want to yolo it, go ahead. I'm far too busy to help with this portion right now. 🍻 |
I don't really know what to test for over there and I'm busy with college myself. If anyone would like to volunteer, please go ahead. |
@DomClark what happened with the CI? |
This reverts commit 4b4650b.
The CI problem was a temporary Chocolatey outage. I reran the affected jobs. |
Sorry for the delay. I've had some time to review the veal changes. They seem to fall into 5 categories:
The only significant change was a refactor to I think the veal stuff is safe to merge. |
Can we merge #6771 then? |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM though I haven't tested it
Nice one everyone 🎉 |
Succeeds #6758, which I messed up after a force push. Luckily, I had an almost identical branch so just merged that branch in.