Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confirmation for channel removal requested when loading another project #7153

Closed
michaelgregorius opened this issue Mar 22, 2024 · 1 comment · Fixed by #7154
Closed

Confirmation for channel removal requested when loading another project #7153

michaelgregorius opened this issue Mar 22, 2024 · 1 comment · Fixed by #7154
Labels
bug

Comments

@michaelgregorius
Copy link
Contributor

michaelgregorius commented Mar 22, 2024 •
edited
Loading

System Information

Linux build (should affect every version)

LMMS Version(s)

3e19d13

Bug Summary

A confirmation dialog for channel removal is shown when loading a new project with another project being already loaded.

Expected Behaviour

No confirmation dialog is shown.

Steps To Reproduce

  1. Load "Greippi - Krem Kaakkuja (Second Flight Remix).mmpz" from the demos.
  2. Click "File > New".

The following confirmation dialog is now shown several times:

LMMSConfirmationBug
@Veratil
Copy link
Contributor

Veratil commented Mar 22, 2024

Ah, unintended side effect of #7081. Need to add a flag to deleteChannel on whether to confirm or not.

@Veratil Veratil mentioned this issue Mar 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MixerView: skip confirmation when using clear Veratil/lmms
2 participants
@Veratil @michaelgregorius