Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlicerT::findSlices - check if lower_bound did not find anything #7214

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Veratil
Copy link
Contributor

@Veratil Veratil commented Apr 21, 2024

Upon loading a sample in SlicerT it attempts to find slices. If std::lower_bound did not find anything it returns zeroCrossing.end() which cannot be dereferenced and causes a vector out of bounds access exception.

@Veratil
Copy link
Contributor Author

Veratil commented Apr 21, 2024

Tagging @DanielKauss since you're the author :)

@Veratil Veratil merged commit 62e2a39 into LMMS:master Apr 23, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants