Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for copy/pasting of effects #7370

Closed
1 task done
0xf0xx0 opened this issue Jul 7, 2024 · 7 comments
Closed
1 task done

Allow for copy/pasting of effects #7370

0xf0xx0 opened this issue Jul 7, 2024 · 7 comments

Comments

@0xf0xx0
Copy link
Contributor

0xf0xx0 commented Jul 7, 2024

Enhancement Summary

Itd be nice to be able to copy and paste effects, like when moving an effect between channels. the current way to copy is to create a new instance of the effect and copy-paste each control.

Implementation Details / Mockup

Reusing the cut/copy/paste buttons from the Song Editor would prolly be the best flow, as the rclick menu is already sparse. plenty of space for three more buttons.

Please search the issue tracker for existing feature requests before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.
@thismoon
Copy link

thismoon commented Jul 7, 2024

Other than adding entries to the rclick/context menu, I would like a Ctrl+drag behavior to copy and paste effects like how it happens with clips in the song editor

@Gabrielxd195
Copy link

Gabrielxd195 commented Jul 7, 2024

I had that same idea, I even designed a mockup with the following buttons.
Copiar y pegar plugins

1- Save Button: This button is to save the plugins that are in the effects chain along with their settings and the order in which they were placed.

2- Remove Button: This button is basically used to remove all plugins from the effects chain.

3- Add Button: This is the classic button for adding plugins.

4- Copy Button: This button will be used to copy all the plugins in the effects chain, with their settings and the order in which they were placed.

5- Paste Button: This button is to paste all the plugins that have been copied from a channel or an instrument, their settings will be pasted in the order in which they were placed.

I want to clarify that these button icons are not from LMMS but from Shotcut, which has this same plugin management model but applied to a video editor. I also added the Copy and Paste options to the menus of each plugin individually, and the ability to drag them. I had that menu in mind, but I forgot to design it. I hope the concept is clear. Thank you

(Google Translate)

@Spekular
Copy link
Member

Spekular commented Jul 8, 2024

Duplicate of #1278 (and two other issues) which has been consolidated into #4877.

@Spekular Spekular closed this as not planned Won't fix, can't repro, duplicate, stale Jul 8, 2024
@Gabrielxd195
Copy link

Duplicate of #1278 (and two other issues) which has been consolidated into #4877.

I understand that they have closed this thread in duplicate, but could you take into account the model of the photo? It would be more intuitive to have these buttons in the effect chain.

@Spekular
Copy link
Member

Spekular commented Jul 8, 2024

I understand that they have closed this thread in duplicate, but could you take into account the model of the photo? It would be more intuitive to have these buttons in the effect chain.

Personally I think it looks quite busy; I don't think e.g. deleting all the effects in a chain is a common enough operation that it needs a button equally prominent to the one for adding effects. However, anyone who tackles this issue is of course free to reference the mockup in their implementation.

@0xf0xx0
Copy link
Contributor Author

0xf0xx0 commented Jul 8, 2024

Duplicate of #1278 (and two other issues) which has been consolidated into #4877.

i wish githubs fuzzy search wasnt so fuzzy sometimes :/

@Gabrielxd195
Copy link

Personally I think it looks quite busy; I don't think e.g. deleting all the effects in a chain is a common enough operation that it needs a button equally prominent to the one for adding effects. However, anyone who tackles this issue is of course free to reference the mockup in their implementation.

The "remove" button is very useful because it immediately removes all the plugins from an instrument or channel that is full, obviously it would be easier to delete the channel and create another one, but what do we do when that channel is a bus that is very busy by many clues?

It is very common for beginners to fill the effects chain due to lack of mixing and mastering knowledge, I think it has happened to all of us in the beginning. This button avoids having to delete all the plugins one by one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants