Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply warning flags to RemoteVstPlugin too #7389

Merged
merged 2 commits into from
Jul 27, 2024

Conversation

DomClark
Copy link
Member

Non-native versions of RemoteVstPlugin are built using CMake's ExternalProject module, so don't pick up flags and things from the main project. This PR ensures that we apply the warning/error flags consistently to all our code.

Changes:

  • Pull the warning/error flag code out into a separate CMake module, so it can be included in both the main project and "external" projects.
  • Bump the CMake version for RemoteVstPlugin to match that of the main project.
  • Forward USE_WERROR to RemoteVstPlugin.
  • Fix warnings currently emitted for RemoteVstPlugin (one fix for each of unused-variable and sign-compare).

Copy link
Contributor

@Rossmaxx Rossmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DomClark DomClark merged commit 627209a into LMMS:master Jul 27, 2024
10 checks passed
@DomClark DomClark deleted the remote-plugin-error-flags branch July 27, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants