-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore some whitespace to the mixer channel layout #7507
Restore some whitespace to the mixer channel layout #7507
Conversation
Since the spacing was reduced to 3, this should not be needed anymore
Thoughts @michaelgregorius? |
This reverts commit b7d8b15.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
If this was mainly about the horizontal space then I'd appreciate if there was a bit more margin at the bottom where the fader ends. Otherwise it looks okay to me. |
Peak indicator at bottom doesn't look good according to me. It seems to increase the view angle, but that might be just me. It's something i cam get used to so it's not really a blocker. |
Yeah, I'll leave it for now but just add some more whitespace at the bottom for the fader. |
Trying to reach a compromise with #7505 and #7502.
I think I initially believed that users were complaining about the spacing being too much horizontally. However, the vertical spacing in
QVBoxLayout
was 6 for me by default, which could be a bit large, and wasn't set to something smaller in #6591.I changed the margin size and spacing to make the mixer channel a bit shorter, while also trying to not compromise useful whitespace.
I'm waiting for two approvals for this PR in particular before merge (I should probably require two approvals in general anyways).
Fixes #7505 (I think)