-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ExprTk #7571
Update ExprTk #7571
Conversation
ArashPartow
commented
Nov 4, 2024
•
edited
Loading
edited
- Moved submodule to release branch
- Release notes: https://www.partow.net/programming/exprtk/exprtk_release_notes_v0.0.3.txt
2a569de
to
4233808
Compare
6ccc786
to
19a34ce
Compare
@gnudles if you don't mind, can you brief us about the effects of updating the submodule. I'm asking you because the rest of us are clueless about the xpressive plugin infrastructure. |
It is the under the hood engine that evaluates the expressions |
Are there any plans to try to cut down on the Xpressive/exprtk binary size? In this PR it is 66.2 MB uncompressed on Linux, while on master it is currently 70.9 MB. That's a little better, but it's still by far the largest single file in the installation after the lmms executable itself. Plus it takes longer than the other plugins to compile. |
@messmerd a large proportion of that would be symbols et al that could be safely removed at least on Linux builds using the
Might also want to do some analysis with bloaty wrt to compilation times. It is not compilation that is slow, but rather linking. It seems that LMMS is using ye-olde ld to link. My suggestion would be to move to gold or even better yet mold or lld. The change to the
Building the ExprTk test suite without and with gold:
|
That's great to see! I'll look into stripping the binaries and using lld or mold. |
It's worth checking why the debugging symbols are there in first place. |