Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring SLSim - Create Catalog class to ingest catalogs or simulation pipeline outputs. #226

Open
4 tasks
jacob-hjortlund opened this issue Aug 6, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jacob-hjortlund
Copy link
Collaborator

Current Status

DeflectorBase and SourcePopBase currently ingest the outputs of SkyPyPipeline instance, the SCOTCH catalog, quasar.class.quasar_sample etc., which all require separate subclasses. Additionally these either a collection of galaxies or point sources, not covering the case where we want associations between the two, see #220. Part of the overall SLSim refactor, see #223.

Proposed Solution

Create a Catalog class that can be ingested by Population. The responsibility of the Catalog class is to adapt the output of a simulation pipeline, i.e SkyPyPipeline, or catalog to the format expected by SLSim and provide it for sampling by the Population class. It should be able to accept either a catalog of galaxies or point sources or both.

To-Do List

  • Create base class.
  • Create SkyPyCatalog subclass for SkyPyPipeline ingestion and adaptation.
  • Create SCOTCHCatalog subclass for ingestion and adaptation of SCOTCH galaxy and transient catalogs.
  • Add unit tests.
@jacob-hjortlund jacob-hjortlund self-assigned this Aug 6, 2024
@jacob-hjortlund jacob-hjortlund added the enhancement New feature or request label Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant