Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks not up to date + minor errors #29

Open
maxime-rey opened this issue May 14, 2019 · 1 comment
Open

Notebooks not up to date + minor errors #29

maxime-rey opened this issue May 14, 2019 · 1 comment

Comments

@maxime-rey
Copy link

Hi, while trying to figure out how spectractor works, I noticed that the notebook weren't up to date.
If I'm not mistaken:

  • In most of them there are the following lines but "../styles/custom.css" doesn't seem to exist.
from IPython.core.display import HTML
def css_styling():
    styles = open("../styles/custom.css", "r").read()
    return HTML(styles)
css_styling()
  • In Run_SpectractorSim.ipynb, the imports should be changed to the following (however, I haven't found what replaced those commented out).
from spectractor.tools import *
#from holo_specs import *
from spectractor.extractor.targets import *
#from optics import *
import spectractor.parameters 

       Furthermore, in the definition of df in the Logbook part, I think that in the files name should be
       'v5' instead of 'v3'. Nonetheless, there is still the error
       ParserError: Error tokenizing data. C error: Expected 5 fields in line 1657, saw 6
       for which I haven't found the solution.

  • In Spectractor tutorial.ipynb, the imports should be as shown below.
    Also, it seems that spec.plot_spectrum(fit=True) should be replace by spec.plot_spectrum(live_fit=True) and the print are still in Python 2.
from spectractor.extractor.extractor import Spectractor 
from spectractor.extractor.spectrum import Spectrum
import spectractor.parameters as parameters 
  • From these I also saw another problems in extractor.py. It should be def Spectractor(config='../config/ctio.ini') instead of def Spectractor(config='./config/ctio.ini').

I hope I didn't say anything stupid and that it helps !

@maxime-rey maxime-rey changed the title Notebook not up to date Notebooks not up to date + minor errors May 14, 2019
@jeremyneveu
Copy link
Collaborator

Hi. Indeed it is not up to date. It should be in my urgent todo list !

@jeremyneveu jeremyneveu mentioned this issue Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants