Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Roadmap #1

Closed
20 of 36 tasks
ismael-mendoza opened this issue Apr 12, 2022 · 9 comments
Closed
20 of 36 tasks

Project Roadmap #1

ismael-mendoza opened this issue Apr 12, 2022 · 9 comments
Labels
plan For roadmaps and high-level discussion on what tasks to do next

Comments

@ismael-mendoza
Copy link
Collaborator

ismael-mendoza commented Apr 12, 2022

Useful links:

Generative Model

Stage 0: Setting things up

Stage 1: Multiband / redshifts/ variable shear

  • single image per band
  • multiband
  • redshift + SEDs
  • variable shear
  • galaxy locations poisson process of 2D density field
  • feed angular power spectrum to galsim/colore -> 2D gaussian density map
  • bin galaxies by true redshift
  • lensing magnifications

Stage2: Blending / Impact of PSF

  • blending effects
  • noisy PSF estimate
  • use correlation functions in PSF

Inference

Stage 0

Goals:

  • connect BLISS with JIF/BFD and recover constant shear
  • start defining what what outputs look like: probabilistic magnitudes + shear

Tasks:

Stage 1

  • BFD is already multi-band (can potentially photo-z)
  • check that we recover power spectrum (?)
  • assume we know true redshift
  • connect with RAIL (?)
    • catalogs: some aspect of photometry + position
    • how to connect posterior samples of photometry
    • tables_io

Stage 2

  • recovering binning (tomo challenge)
  • run on DC2
@ismael-mendoza ismael-mendoza pinned this issue Apr 12, 2022
@EiffL
Copy link
Member

EiffL commented Apr 13, 2022

So, here I propose a slight modification of our baseline plan.

Maybe we can use the https://github.com/LSSTDESC/descwl-shear-sims package to act as our reference implementation for the forward model in stage 0, and stage 0 is adding the code to implement a/several forward model that we will use for inference, validated against that package.

@ismael-mendoza
Copy link
Collaborator Author

Maybe we can use the https://github.com/LSSTDESC/descwl-shear-sims package to act as our reference implementation for the forward model in stage 0

Thanks @EiffL for the suggestion. To make sure I understand - are you suggesting that for stage 0 we use the functions in descwl-shear-sims directly? Or we extract the relevant pieces of code from there (perhaps modified for our needs)?

stage 0 is adding the code to implement a/several forward model that we will use for inference, validated against that package.

What exactly will be validate here ? Our inference methods of shear or the forward model ?

@ismael-mendoza
Copy link
Collaborator Author

ismael-mendoza commented Apr 13, 2022

I also assigned some other pixel-level people in the group to this issue. @rearmstr @mdschneider @aguinot @aboucaud feel free to chime in too :)

EDIT: Please let me know if I missed anyone

@EiffL
Copy link
Member

EiffL commented Apr 14, 2022

yeah, my point is that the descwl-shear-sims is already built around GalSim to emulate the DM images. And it can go from simple images, to all sorts of complex artifacts:
https://github.com/LSSTDESC/descwl-shear-sims/blob/master/tutorials/tutorial-basic.md#simple-simulation

@EiffL
Copy link
Member

EiffL commented Apr 14, 2022

so we can use that as a reference forward model (instead of For now, use galsim in our current plan). We can probably adapt code from that repo at a later stage also.

But yeah, then we implement a matching forward model that would be able to reproduce the same images, and be used in our inference frameworks.

@ismael-mendoza
Copy link
Collaborator Author

That sounds good to me, so for stage 0 we use desc-shear-sims directly for our simulations and as our forward model. We can already try to put together our inference procedures and run them on these sims (we perhaps just choose the flags to not have too many complex artifacts for now).

In later stages we can implement our own forward model that matches this code and do inference on that.

@EiffL
Copy link
Member

EiffL commented Apr 14, 2022

yeah I mean, my thinking was in stage 0 to have the ref. model provided by shear-sims, but we need a separate forwrad model with which to do the inference. Could be from bliss, jif, etc...

@ismael-mendoza
Copy link
Collaborator Author

oh ok, yeah that makes sense now. We still need to build our own forward model whose images can be designed to match the ones in shear-sims

@ismael-mendoza ismael-mendoza added the plan For roadmaps and high-level discussion on what tasks to do next label Apr 22, 2022
@ismael-mendoza
Copy link
Collaborator Author

This list is a bit big and overwhelming. I am closing this in favor of a more focused to-do list for stage0 which I'm about to open. In the future, we can refer back to this list once stage 0 is completed.

@ismael-mendoza ismael-mendoza unpinned this issue Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plan For roadmaps and high-level discussion on what tasks to do next
Projects
None yet
Development

No branches or pull requests

6 participants