Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_pca function not working #152

Closed
Catarina-Alves opened this issue May 24, 2019 · 3 comments
Closed

read_pca function not working #152

Catarina-Alves opened this issue May 24, 2019 · 3 comments
Assignees
@Catarina-Alves
Labels
bug Breaking issue, issue that is causing a program crash or major error enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. pre-v2.0.0 Issues that should be completed prior to public release of v2.0.0

Comments

@Catarina-Alves
Copy link
Collaborator

This method in snfeatures expects PCA_vals.npy, PCA_vecs.npy, PCA_means.npy but they are saved with a different name.

The problem is not in this function but in the one is saving those quantities with the wrong name (and also wrong quantities).

I propose to change the way they are saved.
@Catarina-Alves Catarina-Alves added bug Breaking issue, issue that is causing a program crash or major error enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. pre-v2.0.0 Issues that should be completed prior to public release of v2.0.0 labels May 24, 2019
@Catarina-Alves
Copy link
Collaborator Author

Solving this issue is not as easy as I wrote above. There is a lot of broken code in restarting from the calculated PCA.

@rbiswas4
Copy link
Member

I think this is easier to address if we allow a breaking change, and get consistency between current read write methods but be willing to drop consistency with read write methods of version 1.0.

@Catarina-Alves Catarina-Alves mentioned this issue May 28, 2020
Closed
@Catarina-Alves Catarina-Alves self-assigned this Jun 19, 2020
@Catarina-Alves
Copy link
Collaborator Author

Solved by #219.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Catarina-Alves Catarina-Alves

Labels
bug Breaking issue, issue that is causing a program crash or major error enhancement Improvement to existing functionality or implementation, including adding a new functions/methods. pre-v2.0.0 Issues that should be completed prior to public release of v2.0.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rbiswas4 @Catarina-Alves