Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort the Skill List on the Sender side by Alpha after Localization #58

Closed
akrigline opened this issue Feb 10, 2021 · 3 comments
Closed
Labels
bug Something isn't working

Comments

@akrigline
Copy link
Member

It would be ideal to sort the skill checks list in the request application by Alpha after localization. Currently there is logic to sort the skill checks in the Roller application but not the requester.

@akrigline The issue is still present in 1.8 despite #51
image

Originally posted by @santalucial in #42 (comment)

@akrigline akrigline added the bug Something isn't working label Feb 10, 2021
@santalucial
Copy link

this is already solved by #42 tho there might be better way to handle it with the handlebar lib that i'm unaware of

@akrigline
Copy link
Member Author

akrigline commented Feb 12, 2021

I'm pretty sure that this can be accomplished in the same mechanism by which #51 worked, but I just forgot that the same changes needed to happen to LMRTFYRequestor. This is the perfect use case for localeCompare and Array.sort (which is what 51 leveraged).

@akrigline
Copy link
Member Author

hopefully resolved in 1.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants