Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve price history chart #4

Open
jondubois opened this issue Apr 7, 2020 · 4 comments
Open

Improve price history chart #4

jondubois opened this issue Apr 7, 2020 · 4 comments

Comments

@jondubois
Copy link
Member

Currently, the chart only loads data from the last 100 trades and it reloads the records from the API from time to time.

  • Allow the user to view the price history further back into the past. Possibly with some kind of interactivity so that the user can scroll through the graph and it loads more data on demand. This data could be loaded directly from the blockchain HTTP APIs or it may be better to create a new API endpoint which aggregates price history data in a more efficient way. Any new backend solution should be packaged as an LDEM https://github.com/jondubois/ldem module to ensure that the historical price data can be served in a decentralized way.
  • Consider loading the trades/price data more efficiently (instead of fetching all the latest 100 every time).
@jondubois
Copy link
Member Author

@sacOO7 Feel free to propose a solution before implementing.

@sacOO7
Copy link
Collaborator

sacOO7 commented Apr 24, 2020

Yes.. I for this ... we probably need to make changes to the backend... probably an API that can return data based on pagination. Also, should tell us new transactions available based on last ID passed.

@sacOO7
Copy link
Collaborator

sacOO7 commented Apr 25, 2020

Let me know your thoughts on this, once you get free @jondubois

@jondubois
Copy link
Member Author

The new DEX /prices/recent endpoint supports cursor pagination so we could use this one, but this approach is not as decentralized as reading the price data directly from the affected blockchains and calculating price history on the client side (which is how it works now). It would be nice if the user could choose between the two options depending on their needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants