Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskell-magic-wormhole does not build with recent protolude versions #44

Closed
vu3rdd opened this issue Jun 1, 2020 · 0 comments · Fixed by #46
Closed

haskell-magic-wormhole does not build with recent protolude versions #44

vu3rdd opened this issue Jun 1, 2020 · 0 comments · Fixed by #46

Comments

@vu3rdd
Copy link
Contributor

vu3rdd commented Jun 1, 2020

We make extensive use of toS for type conversions and seem like there were changes in recent release of protolude with respect to the way toS works and eliminates a few conversions that are "partial".

  • it no longer converts from/to Lazy-ByteStrings to ByteStrings.
  • it no longer converts from/to ByteStrings to Strings/Text.

It looks like the following approach would work:

  • for the second one, we need to use encodeUtf8 or decodeUtf8.
  • For the former, we need to replace the use of toS with toStrict/fromStrict as appropriate.

Are there better ways to deal with it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Explicitly hide the non-partial toS and use the partial toS. LeastAuthority/haskell-magic-wormhole
1 participant
@vu3rdd