Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Create a Bluetooth transport that works in Electron #293

Open
gre opened this issue Feb 14, 2019 · 6 comments
Open

Create a Bluetooth transport that works in Electron #293

gre opened this issue Feb 14, 2019 · 6 comments

Comments

@gre
Copy link
Contributor

gre commented Feb 14, 2019

It's unclear weither or not Electron supports Bluetooth out of the box, there is this discussion here electron/electron#7367 but it's not clearly stated and I can't find any documentation in Electron itself. Electron often have a degraded support of Chromium features, don't implement it all so it's worth trying if hw-transport-web-ble works from the renderer thread.

Maybe there are adaptation to do and we can do them, but if navigator.bluetooth is not a thing we'll have to turn to other solution like https://github.com/noble/noble

@PaulBernier
Copy link

I guess it is worth mentioning there that now there is this (experimental) package: https://github.com/LedgerHQ/ledgerjs/tree/master/packages/hw-transport-node-ble

@satb
Copy link

satb commented Jan 11, 2020

Is there any documentation on how to use the hw-transport-web-ble? We can't make head or tail out of what it says over here - https://github.com/LedgerHQ/ledgerjs/tree/master/packages/hw-transport-web-ble

Please list the necessary steps to connect to the X via the browser. What are the calls to be made and in what order? Do you have any example code you can share?

@gre
Copy link
Contributor Author

gre commented Jan 12, 2020

@satb
Copy link

satb commented Jan 12, 2020

@gre - Thank you. But is does the "ledger app" need to make any changes to support ble?

@gre
Copy link
Contributor Author

gre commented Jan 12, 2020

I think most of Nano X apps are compiled to support BLE so it should work.

@satb
Copy link

satb commented Jan 12, 2020

@gre - Unfortunately that doesn't seem to be the case. I opened another issue here. Could you please help figure out? - #440

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants
@gre @satb @PaulBernier and others