Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Valid hex cannot be signed with ethereumSignMessage #338

Open
sidsverma opened this issue Apr 3, 2019 · 8 comments
Open

Valid hex cannot be signed with ethereumSignMessage #338

sidsverma opened this issue Apr 3, 2019 · 8 comments
Assignees

Comments

@sidsverma
Copy link

sidsverma commented Apr 3, 2019

I am trying to do personal_sign some hex string data using metamask on ledger. There is no callback after I sign it on the ledger device.
The code:

async function signPersonalMessage(msgData) {

There is currently no way to sign hex messages using ethereumSignMessage.

@gre gre self-assigned this Dec 22, 2019
@sudoryan
Copy link

Is this issue currently being worked on? Curious about the status here, I have users with ERC721 tokens stuck in their Ledger because of this signing issue. This is affecting the personal_sign method in Metamask + Ledger. Metamask + Trezor had a similar issue, but was fixed when they started accepting hex string data: MetaMask/eth-trezor-keyring#16

@PaulUD
Copy link

PaulUD commented Feb 6, 2020

It would be great if Ledger added support for this.

@WillDotCrypto
Copy link

I agree. Ledger support for this would be very helpful.

@Bird-NZ
Copy link

Bird-NZ commented Feb 9, 2020

Ledger support to sign hex messages is needed. Is there an eta on resolving this?

@PaulUD
Copy link

PaulUD commented Mar 11, 2020

@gre is there any update on this issue?

@Mauro2424
Copy link

@gre Please update. I can't do specific tasks with my ledger device without this.

@LeeeNux
Copy link

LeeeNux commented Apr 6, 2020

any news here?

@DeRain
Copy link

DeRain commented Apr 10, 2020

Hi, it would be great to have support for hex data here.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants