Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: sylvanaar/who-lib
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: Legacy-of-Sylvanaar/who-lib
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Able to merge. These branches can be automatically merged.
  • 7 commits
  • 7 files changed
  • 1 contributor

Commits on Jan 28, 2025

  1. Copy the full SHA
    676be12 View commit details
  2. Rename the library files to 3.0. (GH-1)

    The philosophy betwwen 2.0 and 3.0 is a little bit different. WhoLib
    version 2 tended to handle the /who & usual C_FriendList.SendWho API on
    our own (i.e., queuing them).
    
    The version 3 changed this behavior, and made them much like what they
    will get treated as if they are calling the API themselves.
    
    Therefore, you will get 2 type of API now, one is the original WOW API,
    and the other is the WhoLib one, which is guaranteed to return a result.
    Hudsone committed Jan 28, 2025
    Copy the full SHA
    e63f65b View commit details
  3. Copy the full SHA
    878ceb6 View commit details
  4. Copy the full SHA
    b5fb391 View commit details
  5. Copy the full SHA
    87c8f5c View commit details
  6. Copy the full SHA
    55adbab View commit details
  7. Hard code the version number.

    If we use BigWigsMods Packager to download the library, the version
    number can be incorrect and become 9999.
    
    Also fix a bug referencing global veriable that didn't exist.
    Hudsone committed Jan 28, 2025
    Copy the full SHA
    056cca9 View commit details
Showing with 1,236 additions and 1,398 deletions.
  1. +5 −3 .pkgmeta
  2. +0 −25 LibWho-2.0.toc
  3. +0 −1,119 LibWho-2.0/LibWho-2.0.lua
  4. +23 −0 LibWho-3.0.toc
  5. +69 −251 README.md
  6. +997 −0 src/LibWho-3.0.lua
  7. +142 −0 src/LibWhoTest.lua
8 changes: 5 additions & 3 deletions .pkgmeta
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
package-as: LibWho-2.0

enable-nolib-creation: no

externals:
libs/LibStub: https://repos.wowace.com/wow/libstub/trunk
libs/CallbackHandler-1.0: https://repos.wowace.com/wow/callbackhandler/trunk/CallbackHandler-1.0
libs/LibSimpleTester: https://github.com/Hudsone/lib-simple-tester.git
libs/LibEventChain: https://github.com/Hudsone/lib-event-chain.git

ignore:
- libs/LibStub/tests
- libs/LibStub/LibStub.toc
- "libs/*/*.toc"
- "libs/*/LICENSE"
- "libs/*/README.md"
25 changes: 0 additions & 25 deletions LibWho-2.0.toc

This file was deleted.

Loading