Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Text for deleted and removed comments always returned over API #4663

Closed
5 tasks done
SleeplessOne1917 opened this issue Apr 23, 2024 · 1 comment
Closed
5 tasks done
Labels
area: api area: privacy bug Something isn't working

Comments

@SleeplessOne1917
Copy link
Member

SleeplessOne1917 commented Apr 23, 2024

Requirements

  • Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
  • Did you check to see if this issue already exists?
  • Is this only a single bug? Do not put multiple bugs in one issue.
  • Do you agree to follow the rules in our Code of Conduct?
  • Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

API responses getting comments return deleted and removed ones. I believe this behavior was introduced in #3965. We decided to let clients to handle how to display content. However, we should still not return comment content in the response.

Steps to Reproduce

  1. Hit an endpoint that includes CommentViews
  2. See if any results are deleted and removed. If not, keep paging.
  3. Check comment content in response

Technical Details

n/a

Version

BE 0.19.3

Lemmy Instance URL

lemmygrad.ml, hexbear.net

@SleeplessOne1917 SleeplessOne1917 changed the title [Bug]: Text for deleted and removed [Bug]: Text for deleted and removed comments always returned over API Apr 23, 2024
@SleeplessOne1917
Copy link
Member Author

Handled in #4503

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api area: privacy bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant