-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UAT results / issues to fix now #884
Comments
Hello Mia, As we observed that above testing is done on prod URLS. Please try it with below dev URLS.
Please let us know if you face any other issue. Regards |
My mistake, apologies! I was trying to do the UAT while in a meeting to fit it in. I'm still getting aria and 'tables and lists' errors on https://dev.libcrowds.com/collection/playbills/data https://lighthouse-dot-webdotdevsite.appspot.com//lh/html?url=https%3A%2F%2Fdev.libcrowds.com%2Fcollection%2Fplaybills%2Fdata |
@ashishsinghcoforgetch can you outline the steps needed to resolve the vue-bootstrap issue? |
@mialondon I think there is only one issue is pending related vue-bootstrap and there is an old version of vue-bootstrap so can't update it because it may impact other areas of the portal. |
@hirendrasd is it currently blocking deployment? Looking for instances of the library being imported, it mostly seems to be on information pages, so updating it might have minimal impact. However, it's the not knowing that makes it hard. Is it possible to test on a separate branch? According to https://github.com/LibCrowds/libcrowds/blob/master/package.json the version used is "bootstrap-vue": "^2.0.0-rc.6", and the most current version on https://bootstrap-vue.org/docs/reference/changelog is v2.21.2 so there could be quite a few changes from the rc version. |
@mialondon It's not blocking the deployment. We have already deployed the changes on dev server from master branch. All looking good. Let me plan for production deployment. We can discuss on bootstrap-vue later. |
Testing these core pages with Lighthouse as per the LibCrowds accessibility fixes included in the Statement of Work under the 'Scope & UAT checklist for accessibility fixes' heading:
https://www.libcrowds.com/
https://www.libcrowds.com/collection/playbills
https://www.libcrowds.com/collection/playbills/about
https://www.libcrowds.com/collection/playbills/data
https://www.libcrowds.com/help/privacy
[role]
values are not valid e.g. Report https://lighthouse-dot-webdotdevsite.appspot.com//lh/html?url=https%3A%2F%2Fwww.libcrowds.com%2Fhelp%2FprivacyOn https://www.libcrowds.com/collection/playbills/data Report https://lighthouse-dot-webdotdevsite.appspot.com//lh/html?url=https%3A%2F%2Fwww.libcrowds.com%2Fcollection%2Fplaybills%2Fdata 3 high errors:
[role]
values are not valid[aria-*]
attributes are not valid or misspelledOn https://www.libcrowds.com/collection/playbills Report https://lighthouse-dot-webdotdevsite.appspot.com//lh/html?url=https%3A%2F%2Fwww.libcrowds.com%2Fcollection%2Fplaybills 3 high errors:
[role]
values are not valid[alt]
attributes - for images in the code (as opposed to the markdown), please add empty alt tagsThe text was updated successfully, but these errors were encountered: