Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfbInitClient() does not parse IPv6 addresses correctly #436

Open
bk138 opened this issue Jul 17, 2020 · 3 comments
Open

rfbInitClient() does not parse IPv6 addresses correctly #436

bk138 opened this issue Jul 17, 2020 · 3 comments
Labels
Milestone

Comments

@bk138
Copy link
Member

bk138 commented Jul 17, 2020

No description provided.

@bk138 bk138 added the bug label Jul 17, 2020
@bk138 bk138 added this to the Release 1.0.0 milestone Jul 17, 2020
@bk138 bk138 self-assigned this Jul 17, 2020
@bk138
Copy link
Member Author

bk138 commented Jul 17, 2020

	  char* colon = NULL;
	  size_t colon_count = 0;
	  char *str = argv[i];
	  while(str && *str) {
	      if(*str == ':')
		  ++colon_count;
	      ++str;
	  }

	  if(colon_count > 1) {
	      /* probably IPv6, need [] to parse port */
	      char *closingbracket = strrchr(argv[i],']');
	      if(closingbracket && *(closingbracket+1) == ':')
		  colon = closingbracket+1;
	  } else
	      colon = strrchr(argv[i],':');

@willbprog127
Copy link

Greetings!

Is there any progress on this bug? My open-source project uses libvncclient and I cannot gain access to IPv6 servers - I receive "Unable to assign address" from libvncclient when trying.

Sorry, due to certain circumstances, I'm unable to submit a patch.

Thanks! 👍

@bk138
Copy link
Member Author

bk138 commented Mar 16, 2023

Hi @willbprog127 this will still take some time if I do it, I'm currently overwhelmed with job-related work.

@bk138 bk138 removed their assignment Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants