Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hashbrown dependency? #31

Open
richarddd opened this issue Feb 7, 2024 · 3 comments
Open

Remove hashbrown dependency? #31

richarddd opened this issue Feb 7, 2024 · 3 comments

Comments

@richarddd
Copy link

richarddd commented Feb 7, 2024

Maybe i'm missing something here but since Rust 1.36, hashbrown is now the HashMap implementation for the Rust standard library so is the dependency needed?

And then you can use use the default HashMap with an ahash or fxhash or pull in that dependency. fxhash was the most performant (not cryptographically safe) when used in rustc https://nnethercote.github.io/perf-book/hashing.html but of many cases ahash is faster

Or even better, use the default hashset and feature gate fxhash or ahash algorithms defaulting to ahash 🥇

@Licenser
Copy link
Owner

Licenser commented Feb 7, 2024

The standard HashMap hasn't stabilized the RawEntry API which hashbrowns (and halfbrown) exposes once that is stabelized in core-rust we don't need hashbrowns any more :)

@jqnatividad
Copy link

Perhaps, release halfbrown 0.2.5 with the latest hashbrown in the meantime?

#30

@richarddd
Copy link
Author

@Licenser would you consider upgrading to latest halfbrown? I'm getting duplicate deps on hashbrown v0.15.2 and this v0.14.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants